Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2833533002: Make sure feedback app footer buttons stick to the bottom (Closed)

Created:
3 years, 8 months ago by afakhry
Modified:
3 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org, apacible+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure feedback app footer buttons stick to the bottom If item get removed from the content pane, the buttons should always remain at the bottom. BUG=712539 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2833533002 Cr-Commit-Position: refs/heads/master@{#465708} Committed: https://chromium.googlesource.com/chromium/src/+/f1fbbd6d02b15123242c4782ca8830048d300e55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/feedback/css/feedback.css View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
afakhry
Xiyuan, please take a look. Thanks!
3 years, 8 months ago (2017-04-19 17:06:04 UTC) #3
xiyuan
lgtm
3 years, 8 months ago (2017-04-19 18:16:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833533002/1
3 years, 8 months ago (2017-04-19 18:27:00 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 19:34:13 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f1fbbd6d02b15123242c4782ca88...

Powered by Google App Engine
This is Rietveld 408576698