chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc - Issue 2833523002: Adding opt out and previews type information to DRP pingback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc

Issue 2833523002: Adding opt out and previews type information to DRP pingback (Closed)

Patch Set: moved definition up Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc ('K') | « chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc » ('j') | chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc

index d8e9e8c574e435a4ba2b7654605ef6323a254bf5..3052c23e4ed04192159241502c3af1e6341f0f67 100644

--- a/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc

@@ -56,19 +56,19 @@ class MediaPageLoadMetricsObserverTest

page_load_metrics::ExtraRequestInfo resources[] = {

// Cached request.

{true /*was_cached*/, 1024 * 40 /* raw_body_bytes */,

- false /* data_reduction_proxy_used*/,

+ false /* data_reduction_proxy_used*/, false /* was_lofi_response */,

bengr 2017/04/20 17:36:18 two spaces.

RyanSturm 2017/04/20 20:25:44 Acknowledged.

0 /* original_network_content_length */},

// Uncached non-proxied request.

{false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,

- false /* data_reduction_proxy_used*/,

+ false /* data_reduction_proxy_used*/, false /* was_lofi_response */,

1024 * 40 /* original_network_content_length */},

// Uncached proxied request with .1 compression ratio.

{false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,

- false /* data_reduction_proxy_used*/,

+ false /* data_reduction_proxy_used*/, false /* was_lofi_response */,

1024 * 40 /* original_network_content_length */},

// Uncached proxied request with .5 compression ratio.

{false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,

- false /* data_reduction_proxy_used*/,

+ false /* data_reduction_proxy_used*/, false /* was_lofi_response */,

1024 * 40 /* original_network_content_length */},

};