Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2833463003: Permissions/Mac: Fix missing right padding for Cocoa permission prompt bubbles. (Closed)

Created:
3 years, 8 months ago by Patti Lor
Modified:
3 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Permissions/Mac: Fix missing right padding for Cocoa permission prompt bubbles. See https://drive.google.com/open?id=0BzEa5HU1aAqBRnJ3N2xTV2JTU2M for before / after screenshots. BUG=709116 Review-Url: https://codereview.chromium.org/2833463003 Cr-Commit-Position: refs/heads/master@{#466199} Committed: https://chromium.googlesource.com/chromium/src/+/ca8708632799fafe05e889d5a026249fa630dbab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Patti Lor
Hi Robert, PTAL? Thanks!
3 years, 8 months ago (2017-04-20 04:01:11 UTC) #7
Robert Sesek
lgtm
3 years, 8 months ago (2017-04-20 15:33:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833463003/1
3 years, 8 months ago (2017-04-21 00:26:10 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 00:35:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ca8708632799fafe05e889d5a026...

Powered by Google App Engine
This is Rietveld 408576698