Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2833423003: Animated scroll shouldn't require main-frame for OOPIFs. (Closed)

Created:
3 years, 8 months ago by wjmaclean
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Animated scroll shouldn't require main-frame for OOPIFs. At present the animated scroll code for mouse wheels will mark as SCROLL_ON_IMPL any attempt to scroll if there is no scrollable layer, and in an OOPIF this causes the GestureScrollUpdate to be marked as consumed when in fact it isn't. In turn, this prevents the GestureScrollUpdate from bubbling to the embedder. This CL fixes LayerTreeHostImpl::ScrollAnimated() to corrently report such GestureScrollUpdate events as ignored, so they can bubble to the embedder. This CL has no behavioral changes for Mac, as it does not support smooth scrolling. BUG=701178 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2785533003 Cr-Commit-Position: refs/heads/master@{#465828} (cherry picked from commit a755e30003e89da8ed1ee6f9e4e039acb395e3af) Review-Url: https://codereview.chromium.org/2833423003 . Cr-Commit-Position: refs/branch-heads/3071@{#166} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/bd145783f35871897d7bcf24b194cae2631186b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -4 lines) Patch
M cc/test/layer_tree_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/test/stub_layer_tree_host_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/test/stub_layer_tree_host_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/layouttest_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/compositor/compositor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wjmaclean
3 years, 8 months ago (2017-04-24 17:06:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd145783f35871897d7bcf24b194cae2631186b3.

Powered by Google App Engine
This is Rietveld 408576698