Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2833383002: Remove redundant SupportsWeakPtr from BrowserControlsOffsetManager (Closed)

Created:
3 years, 8 months ago by Chandan
Modified:
3 years, 8 months ago
CC:
bokan, cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant SupportsWeakPtr from BrowserControlsOffsetManager BrowserControlsOffsetManager unnecessarily inherits from SupportsWeakPtr. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2833383002 Cr-Commit-Position: refs/heads/master@{#466698} Committed: https://chromium.googlesource.com/chromium/src/+/89c16baa8273f797ed026079633dbb80fd191c12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M cc/input/browser_controls_offset_manager.h View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Chandan
PTAL. Thank you.
3 years, 8 months ago (2017-04-24 10:50:56 UTC) #3
aelias_OOO_until_Jul13
lgtm
3 years, 8 months ago (2017-04-24 18:25:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833383002/1
3 years, 8 months ago (2017-04-24 18:33:39 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 18:40:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/89c16baa8273f797ed026079633d...

Powered by Google App Engine
This is Rietveld 408576698