Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2833373004: Use TaskScheduler instead of blocking pool in safe_browsing_service.cc. (Closed)

Created:
3 years, 8 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
Jialiu Lin
CC:
chromium-reviews, grt+watch_chromium.org, vakh+watch_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of blocking pool in safe_browsing_service.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=jialiul@chromium.org Review-Url: https://codereview.chromium.org/2833373004 Cr-Commit-Position: refs/heads/master@{#467693} Committed: https://chromium.googlesource.com/chromium/src/+/e79777a2947a3887983485354e03c756970c7241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_service.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
fdoray
3 years, 8 months ago (2017-04-24 18:45:04 UTC) #1
fdoray
PTAL! This CL was generated automatically. Please make sure that the appropriate TaskTraits are used ...
3 years, 8 months ago (2017-04-24 18:45:06 UTC) #3
Jialiu Lin
LGTM. Thanks for addressing this deprecation!
3 years, 8 months ago (2017-04-26 18:20:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833373004/1
3 years, 8 months ago (2017-04-26 18:30:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/280313)
3 years, 8 months ago (2017-04-26 19:36:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833373004/1
3 years, 7 months ago (2017-04-27 13:37:15 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 15:51:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e79777a2947a3887983485354e03...

Powered by Google App Engine
This is Rietveld 408576698