Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8535)

Unified Diff: chrome/browser/ui/views/frame/minimize_button_metrics_win.h

Issue 2833363002: Add GetCaptionButtonHeightInDIPs() method (Closed)
Patch Set: Made MinimizeButtonMetrics::GetCaptionButtonHeight() static and reverted the rest of the changes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/minimize_button_metrics_win.h
diff --git a/chrome/browser/ui/views/frame/minimize_button_metrics_win.h b/chrome/browser/ui/views/frame/minimize_button_metrics_win.h
index c3a6d3f34bbf82a68d207684750dc51576c1e4e1..6eb7f4cb5a8f6beb193160e501f475d0a3571a90 100644
--- a/chrome/browser/ui/views/frame/minimize_button_metrics_win.h
+++ b/chrome/browser/ui/views/frame/minimize_button_metrics_win.h
@@ -18,6 +18,9 @@ class MinimizeButtonMetrics {
MinimizeButtonMetrics();
~MinimizeButtonMetrics();
+ // Get the height of the native caption buttons in DIPs.
Peter Kasting 2017/04/26 17:19:52 Nit: Get -> Returns (make comments declarative, no
+ static int GetCaptionButtonHeight();
+
void Init(HWND hwnd);
// Obtain the X offset of the native minimize button. Since Windows can lie
@@ -48,7 +51,7 @@ class MinimizeButtonMetrics {
// Static cache of |cached_minimize_button_x_delta_|.
static int last_cached_minimize_button_x_delta_;
- // Static cache of offset value representing the different between
+ // Static cache of offset value representing the difference between
// DWMWA_CAPTION_BUTTON_BOUNDS and WM_GETTITLEBARINFOEX
static int button_bounds_position_offset_;

Powered by Google App Engine
This is Rietveld 408576698