Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Side by Side Diff: chrome/browser/ui/views/frame/minimize_button_metrics_win.h

Issue 2833363002: Add GetCaptionButtonHeightInDIPs() method (Closed)
Patch Set: Made MinimizeButtonMetrics::GetCaptionButtonHeight() static and reverted the rest of the changes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_MINIMIZE_BUTTON_METRICS_WIN_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_MINIMIZE_BUTTON_METRICS_WIN_H_
6 #define CHROME_BROWSER_UI_VIEWS_FRAME_MINIMIZE_BUTTON_METRICS_WIN_H_ 6 #define CHROME_BROWSER_UI_VIEWS_FRAME_MINIMIZE_BUTTON_METRICS_WIN_H_
7 7
8 #include <windows.h> 8 #include <windows.h>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 11
12 // Class that implements obtaining the X coordinate of the native minimize 12 // Class that implements obtaining the X coordinate of the native minimize
13 // button for the native frame on Windows. 13 // button for the native frame on Windows.
14 // This is a separate class because obtaining it is somewhat tricky and this 14 // This is a separate class because obtaining it is somewhat tricky and this
15 // code is shared between BrowserDesktopWindowTreeHostWin and BrowserFrameWin. 15 // code is shared between BrowserDesktopWindowTreeHostWin and BrowserFrameWin.
16 class MinimizeButtonMetrics { 16 class MinimizeButtonMetrics {
17 public: 17 public:
18 MinimizeButtonMetrics(); 18 MinimizeButtonMetrics();
19 ~MinimizeButtonMetrics(); 19 ~MinimizeButtonMetrics();
20 20
21 // Get the height of the native caption buttons in DIPs.
Peter Kasting 2017/04/26 17:19:52 Nit: Get -> Returns (make comments declarative, no
22 static int GetCaptionButtonHeight();
23
21 void Init(HWND hwnd); 24 void Init(HWND hwnd);
22 25
23 // Obtain the X offset of the native minimize button. Since Windows can lie 26 // Obtain the X offset of the native minimize button. Since Windows can lie
24 // to us if we call this at the wrong moment, this might come from a cached 27 // to us if we call this at the wrong moment, this might come from a cached
25 // value rather than read when called. 28 // value rather than read when called.
26 int GetMinimizeButtonOffsetX() const; 29 int GetMinimizeButtonOffsetX() const;
27 30
28 // Must be called when hwnd_ is activated to update the minimize button 31 // Must be called when hwnd_ is activated to update the minimize button
29 // position cache. 32 // position cache.
30 void OnHWNDActivated(); 33 void OnHWNDActivated();
(...skipping 10 matching lines...) Expand all
41 HWND hwnd_; 44 HWND hwnd_;
42 45
43 // Cached offset of the minimize button. If RTL this is the location of the 46 // Cached offset of the minimize button. If RTL this is the location of the
44 // minimize button, if LTR this is the offset from the right edge of the 47 // minimize button, if LTR this is the offset from the right edge of the
45 // client area to the minimize button. 48 // client area to the minimize button.
46 mutable int cached_minimize_button_x_delta_; 49 mutable int cached_minimize_button_x_delta_;
47 50
48 // Static cache of |cached_minimize_button_x_delta_|. 51 // Static cache of |cached_minimize_button_x_delta_|.
49 static int last_cached_minimize_button_x_delta_; 52 static int last_cached_minimize_button_x_delta_;
50 53
51 // Static cache of offset value representing the different between 54 // Static cache of offset value representing the difference between
52 // DWMWA_CAPTION_BUTTON_BOUNDS and WM_GETTITLEBARINFOEX 55 // DWMWA_CAPTION_BUTTON_BOUNDS and WM_GETTITLEBARINFOEX
53 static int button_bounds_position_offset_; 56 static int button_bounds_position_offset_;
54 57
55 // Has OnHWNDActivated() been invoked? 58 // Has OnHWNDActivated() been invoked?
56 bool was_activated_; 59 bool was_activated_;
57 60
58 DISALLOW_COPY_AND_ASSIGN(MinimizeButtonMetrics); 61 DISALLOW_COPY_AND_ASSIGN(MinimizeButtonMetrics);
59 }; 62 };
60 63
61 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_MINIMIZE_BUTTON_METRICS_WIN_H_ 64 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_MINIMIZE_BUTTON_METRICS_WIN_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698