Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2833303004: Update WATCHLISTS and OWNERS for chromedriver (Closed)

Created:
3 years, 8 months ago by johnchen
Modified:
3 years, 8 months ago
Reviewers:
stgao
CC:
chromium-reviews, johnchen+watch_chromium.org, samuong
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update WATCHLISTS and OWNERS for chromedriver BUG= Review-Url: https://codereview.chromium.org/2833303004 Cr-Commit-Position: refs/heads/master@{#467034} Committed: https://chromium.googlesource.com/chromium/src/+/302ecd60a8d39c4684bb148fbead2097d9b989d9

Patch Set 1 #

Patch Set 2 : Add clarification about primary vs backup reviewer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M WATCHLISTS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/OWNERS View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
johnchen
Shuotao: PTAL Sam: Not sure if you still want to keep an eye on ChromeDriver ...
3 years, 8 months ago (2017-04-24 18:19:08 UTC) #2
stgao
lgtm
3 years, 8 months ago (2017-04-24 18:20:55 UTC) #3
johnchen
Shuotao: To make it easier for people submitting reviews, I added comments to indicate primary ...
3 years, 8 months ago (2017-04-25 04:51:06 UTC) #4
stgao
On 2017/04/25 04:51:06, johnchen wrote: > Shuotao: To make it easier for people submitting reviews, ...
3 years, 8 months ago (2017-04-25 05:36:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833303004/20001
3 years, 8 months ago (2017-04-25 17:11:48 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 17:23:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/302ecd60a8d39c4684bb148fbead...

Powered by Google App Engine
This is Rietveld 408576698