Adopt base::OnceCallback in base::BarrierClosure

Adopt base::OnceCallback in base::BarrierClosure

base::BarrierClosure calls the given callback object only once upon the
Nth invocation of resulting wrapper callback. That means, the wrapped
callback should be OnceCallback, and the resulting callback should be
RepeatingCallback.

BUG=714018
Review-Url: https://codereview.chromium.org/2833293004
Cr-Commit-Position: refs/heads/master@{#467664}
Committed: https://chromium.googlesource.com/chromium/src/+/34bf6052665ebb01cfd3dba05e2e72a64e08da67

[tzik, 2017-04-25 13:48:25]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 13:48:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 14:49:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 14:49:40]

Dry run: This issue passed the CQ dry run.

[tzik, 2017-04-26 04:25:47]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 04:26:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-04-26 04:31:23]

Description was changed from

==========
Adopt base::OnceCallback in base::BarrierClosure

BUG=
==========

to

==========
Adopt base::OnceCallback in base::BarrierClosure

base::BarrierClosure calls the given callback object only once upon the
Nth invocation of resulting wrapper callback. That means, the wrapped
callback should be OnceCallback, and the resulting callback should be
RepeatingCallback.

BUG=
==========

[tzik, 2017-04-26 04:39:03]

Description was changed from

==========
Adopt base::OnceCallback in base::BarrierClosure

base::BarrierClosure calls the given callback object only once upon the
Nth invocation of resulting wrapper callback. That means, the wrapped
callback should be OnceCallback, and the resulting callback should be
RepeatingCallback.

BUG=
==========

to

==========
Adopt base::OnceCallback in base::BarrierClosure

base::BarrierClosure calls the given callback object only once upon the
Nth invocation of resulting wrapper callback. That means, the wrapped
callback should be OnceCallback, and the resulting callback should be
RepeatingCallback.

BUG=714018
==========

[tzik, 2017-04-26 05:24:56]

tzik@chromium.org changed reviewers:
+ gab@chromium.org

[tzik, 2017-04-26 05:24:57]

PTAL

[commit-bot: I haz the power, 2017-04-26 05:48:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 05:48:56]

Dry run: This issue passed the CQ dry run.

[gab, 2017-04-26 15:07:25]

lgtm w/ comment

https://codereview.chromium.org/2833293004/diff/20001/base/barrier_closure.h
File base/barrier_closure.h (right):

https://codereview.chromium.org/2833293004/diff/20001/base/barrier_closure.h#...
base/barrier_closure.h:24: // will be released on.
This change voids this last paragraph, right?

[tzik, 2017-04-27 12:09:44]

https://codereview.chromium.org/2833293004/diff/20001/base/barrier_closure.h
File base/barrier_closure.h (right):

https://codereview.chromium.org/2833293004/diff/20001/base/barrier_closure.h#...
base/barrier_closure.h:24: // will be released on.
On 2017/04/26 15:07:25, gab wrote:
> This change voids this last paragraph, right?

Right, updated the comment.

[tzik, 2017-04-27 12:09:49]

The CQ bit was checked by tzik@chromium.org

[tzik, 2017-04-27 12:09:49]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2833293004/#ps40001
(title: "update comment")

[commit-bot: I haz the power, 2017-04-27 12:09:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 14:03:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493294989306120,
"parent_rev": "77a3d68357be0360ccbc2177ce6ca75cd596646b", "commit_rev":
"34bf6052665ebb01cfd3dba05e2e72a64e08da67"}

[commit-bot: I haz the power, 2017-04-27 14:03:34]

Description was changed from

==========
Adopt base::OnceCallback in base::BarrierClosure

base::BarrierClosure calls the given callback object only once upon the
Nth invocation of resulting wrapper callback. That means, the wrapped
callback should be OnceCallback, and the resulting callback should be
RepeatingCallback.

BUG=714018
==========

to

==========
Adopt base::OnceCallback in base::BarrierClosure

base::BarrierClosure calls the given callback object only once upon the
Nth invocation of resulting wrapper callback. That means, the wrapped
callback should be OnceCallback, and the resulting callback should be
RepeatingCallback.

BUG=714018

Review-Url: https://codereview.chromium.org/2833293004
Cr-Commit-Position: refs/heads/master@{#467664}
Committed:
https://chromium.googlesource.com/chromium/src/+/34bf6052665ebb01cfd3dba05e2e...
==========

[commit-bot: I haz the power, 2017-04-27 14:03:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/34bf6052665ebb01cfd3dba05e2e...