Chromium Code Reviews
DescriptionDon't include descendants into LocalVisualRect if a box has both mask and overflow clip
This avoids unnecessary paint invalidation when the box's descedants
change visual overflow which doesn't affect the box's local visual rect
because of the overflow clip.
About the bug: the page contains the following HTML:
<div style="overflow: hidden; -webkit-mask-image: url(#a)>
<div class="animating rotation transform"></div>
</div>
The animating child changes the container's layout overflow.
https://codereview.chromium.org/2791933003/ fixed an under-invalidation
issue when layout overflow changes, but unnecessarily invalidated the
container because previously LayoutBox::LocalVisualRect() also included
descendant visual overflow if there is a mask regardless of overflow
clip.
BUG=709054
Review-Url: https://codereview.chromium.org/2826273005
Cr-Commit-Position: refs/heads/master@{#466243}
TBR=wangxianzhu@chromium.org
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2833263002
Cr-Commit-Position: refs/branch-heads/3071@{#141}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/198917a86accada7eb94e50b93ca0a7253fce823
Patch Set 1 #
Messages
Total messages: 5 (3 generated)
|
||||||||||||||||||||||||||||