Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2833253002: supersize: Parse build.ninja concurrently (Closed)

Created:
3 years, 8 months ago by agrieve
Modified:
3 years, 8 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

supersize: Parse build.ninja concurrently Speeds archive up by a couple seconds. This also adds a work-around for the process not exiting when an exception is thrown (or Ctrl-C is pressed) in the main process and a helper process is still active. BUG=681694 Review-Url: https://codereview.chromium.org/2833253002 Cr-Commit-Position: refs/heads/master@{#466635} Committed: https://chromium.googlesource.com/chromium/src/+/11bfa89469cf59b8a5792f5cbfb8f0d2ed9ae48b

Patch Set 1 #

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -81 lines) Patch
M tools/binary_size/libsupersize/archive.py View 1 5 chunks +14 lines, -23 lines 0 comments Download
M tools/binary_size/libsupersize/helpers.py View 1 chunk +32 lines, -0 lines 0 comments Download
M tools/binary_size/libsupersize/ninja_parser.py View 2 chunks +60 lines, -58 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
agrieve
On 2017/04/24 13:44:25, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org 🛀
3 years, 8 months ago (2017-04-24 13:44:41 UTC) #3
estevenson
lgtm
3 years, 8 months ago (2017-04-24 14:40:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833253002/20001
3 years, 8 months ago (2017-04-24 15:45:29 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 15:59:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/11bfa89469cf59b8a5792f5cbfb8...

Powered by Google App Engine
This is Rietveld 408576698