Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2833223002: Removed superfluous custom style DCHECK. (Closed)

Created:
3 years, 8 months ago by rune
Modified:
3 years, 8 months ago
Reviewers:
nainar
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed superfluous custom style DCHECK. Custom style callbacks are called during style recalc. There is no need to check that ShadowRoot does not have such callbacks during layout tree rebuild. There is already a check in ShadowRoot::RecalcStyle(). R=nainar@chromium.org BUG=595137 Review-Url: https://codereview.chromium.org/2833223002 Cr-Commit-Position: refs/heads/master@{#466551} Committed: https://chromium.googlesource.com/chromium/src/+/e0a99ba807c98cb277234bb9ea557549bbf91aa8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
rune
ptal
3 years, 8 months ago (2017-04-21 23:45:58 UTC) #2
nainar
lgtm
3 years, 8 months ago (2017-04-21 23:47:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833223002/1
3 years, 8 months ago (2017-04-22 08:30:48 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-22 19:28:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e0a99ba807c98cb277234bb9ea55...

Powered by Google App Engine
This is Rietveld 408576698