chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc - Issue 2833213002: DevTools: retain DTAH in all the targets to match their life time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc

Issue 2833213002: DevTools: retain DTAH in all the targets to match their life time. (Closed)

Patch Set: for landing Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/tab_android.cc ('K') | « chromecast/browser/devtools/cast_devtools_manager_delegate.cc ('k') | content/browser/devtools/devtools_agent_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc

diff --git a/chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc b/chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc

index f11c7bd7b03e871bea45c6f40bd07bbafe0431e6..fe821ec8d133301b084d42562c048b73ac44b56e 100644

--- a/chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc

+++ b/chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc

@@ -61,9 +61,8 @@ TEST_F(CastDevToolsManagerDelegateTest, TestSingletonGetter) {

}

TEST_F(CastDevToolsManagerDelegateTest, NoWebContents) {

- EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets(

- base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets,

- base::Unretained(this), WebContentsSet())));

+ EXPECT_TRUE(TestDiscoveredTargets(

+ WebContentsSet(), devtools_manager_delegate_->RemoteDebuggingTargets()));

}

TEST_F(CastDevToolsManagerDelegateTest, DisabledWebContents) {