Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Side by Side Diff: chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc

Issue 2833213002: DevTools: retain DTAH in all the targets to match their life time. (Closed)
Patch Set: for landing Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromecast/browser/devtools/cast_devtools_manager_delegate.h" 5 #include "chromecast/browser/devtools/cast_devtools_manager_delegate.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <unordered_set> 8 #include <unordered_set>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 private: 54 private:
55 DISALLOW_COPY_AND_ASSIGN(CastDevToolsManagerDelegateTest); 55 DISALLOW_COPY_AND_ASSIGN(CastDevToolsManagerDelegateTest);
56 }; 56 };
57 57
58 TEST_F(CastDevToolsManagerDelegateTest, TestSingletonGetter) { 58 TEST_F(CastDevToolsManagerDelegateTest, TestSingletonGetter) {
59 EXPECT_EQ(devtools_manager_delegate_.get(), 59 EXPECT_EQ(devtools_manager_delegate_.get(),
60 CastDevToolsManagerDelegate::GetInstance()); 60 CastDevToolsManagerDelegate::GetInstance());
61 } 61 }
62 62
63 TEST_F(CastDevToolsManagerDelegateTest, NoWebContents) { 63 TEST_F(CastDevToolsManagerDelegateTest, NoWebContents) {
64 EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets( 64 EXPECT_TRUE(TestDiscoveredTargets(
65 base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets, 65 WebContentsSet(), devtools_manager_delegate_->RemoteDebuggingTargets()));
66 base::Unretained(this), WebContentsSet())));
67 } 66 }
68 67
69 TEST_F(CastDevToolsManagerDelegateTest, DisabledWebContents) { 68 TEST_F(CastDevToolsManagerDelegateTest, DisabledWebContents) {
70 EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets( 69 EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets(
71 base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets, 70 base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets,
72 base::Unretained(this), WebContentsSet()))); 71 base::Unretained(this), WebContentsSet())));
73 } 72 }
74 73
75 TEST_F(CastDevToolsManagerDelegateTest, EnabledWebContents) { 74 TEST_F(CastDevToolsManagerDelegateTest, EnabledWebContents) {
76 devtools_manager_delegate_->EnableWebContentsForDebugging(web_contents()); 75 devtools_manager_delegate_->EnableWebContentsForDebugging(web_contents());
77 WebContentsSet enabled_web_contents({web_contents()}); 76 WebContentsSet enabled_web_contents({web_contents()});
78 EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets( 77 EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets(
79 base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets, 78 base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets,
80 base::Unretained(this), enabled_web_contents))); 79 base::Unretained(this), enabled_web_contents)));
81 } 80 }
82 81
83 } // namespace shell 82 } // namespace shell
84 } // namespace chromecast 83 } // namespace chromecast
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698