Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Issue 2833133002: Replace ASSERT_NOT_REACHED with NOTREACHED in modules/webgl (Closed)

Created:
3 years, 8 months ago by pilgrim_google
Modified:
3 years, 8 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, chromium-reviews, jsbell
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT_NOT_REACHED with NOTREACHED in modules/webgl BUG=707642 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2833133002 Cr-Commit-Position: refs/heads/master@{#466364} Committed: https://chromium.googlesource.com/chromium/src/+/42ccb94de63888830e4dfaead1e22cae2ed9a447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
pilgrim_google
3 years, 8 months ago (2017-04-21 14:45:42 UTC) #4
haraken
LGTM
3 years, 8 months ago (2017-04-21 14:46:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833133002/1
3 years, 8 months ago (2017-04-21 14:51:27 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 16:48:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/42ccb94de63888830e4dfaead1e2...

Powered by Google App Engine
This is Rietveld 408576698