third_party/WebKit/Source/platform/wtf/text/TextCodecUTF16.cpp - Issue 2833123002: Replace ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/wtf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/wtf/text/TextCodecUTF16.cpp

Issue 2833123002: Replace ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/wtf (Closed)

Patch Set: wtf Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/wtf/text/TextCodecUTF16.cpp

diff --git a/third_party/WebKit/Source/platform/wtf/text/TextCodecUTF16.cpp b/third_party/WebKit/Source/platform/wtf/text/TextCodecUTF16.cpp

index 4d4259fce2ca1358959f31e0b320036244b28477..ccf6a89a134e67c3680787a10d3e1ad6ed3f654d 100644

--- a/third_party/WebKit/Source/platform/wtf/text/TextCodecUTF16.cpp

+++ b/third_party/WebKit/Source/platform/wtf/text/TextCodecUTF16.cpp

@@ -189,7 +189,7 @@ CString TextCodecUTF16::Encode(const LChar* characters,

size_t length,

UnencodableHandling) {

// In the LChar case, we do actually need to perform this check in release. :)

- RELEASE_ASSERT(length <= numeric_limits<size_t>::max() / 2);

+ CHECK_LE(length, numeric_limits<size_t>::max() / 2);

char* bytes;

CString result = CString::CreateUninitialized(length * 2, bytes);