environ: Fix key case, add GetEmpty and Remove.

environ: Fix key case, add GetEmpty and Remove.

The "environ" package does not ignore the case of enviornment variable
keys on Windows. This patch fixes this bug by allowing an Env to be
configured to be case insensitive, and having Windows systems default to
"true".

Creation methods "System" and "New" will both default to the case
sensitivity of the current operating system.

Additionally, this patch adds Remove, which allows for the deletion of
enviornment variables, and GetEmpty, which offers an interface similar
to "os.Getenv".

BUG=chromium:714165
TEST=unit

Review-Url: https://codereview.chromium.org/2833073004
Committed: https://github.com/luci/luci-go/commit/fde97cf33c7fad766b10ad40b5cbc10830d5749f

[dnj, 2017-04-21 15:45:33]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org, vadimsh@chromium.org

[dnj, 2017-04-21 15:45:33]

*sigh* PTAL

[Vadim Sh., 2017-04-21 16:39:07]

On Linux and OSX the environment is case sensitive, on Windows - it's not.
Search for "case-sensitive" on this page
https://en.wikipedia.org/wiki/Environment_variable

[dnj, 2017-04-21 16:49:30]

On 2017/04/21 16:39:07, Vadim Sh. wrote:
> On Linux and OSX the environment is case sensitive, on Windows - it's not.
> Search for "case-sensitive" on this page
> https://en.wikipedia.org/wiki/Environment_variable

Ah that makes sense. I think that I knew this at some point.

[dnj, 2017-04-21 17:29:27]

Description was changed from

==========
environ: Fix key case, add GetEmpty and Remove.

The "environ" package does not ignore the case of enviornment variable
keys. This patch fixes this bug by storing and keying the variables
as upper-case in the underlying map.

Additionally, this patch adds Remove, which allows for the deletion of
enviornment variables, and GetEmpty, which offers an interface similar
to "os.Getenv".

BUG=chromium:714165
TEST=unit
==========

to

==========
environ: Fix key case, add GetEmpty and Remove.

The "environ" package does not ignore the case of enviornment variable
keys on Windows. This patch fixes this bug by allowing an Env to be
configured to be case insensitive, and having Windows systems default to
"true".

Creation methods "System" and "New" will both default to the case
sensitivity of the current operating system.

Additionally, this patch adds Remove, which allows for the deletion of
enviornment variables, and GetEmpty, which offers an interface similar
to "os.Getenv".

BUG=chromium:714165
TEST=unit
==========

[dnj, 2017-04-21 17:39:01]

PTAL, updated to be OS-aware.

[Vadim Sh., 2017-04-21 17:43:26]

lgtm

[dnj, 2017-04-21 18:07:04]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-04-21 18:07:05]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2833073004/#ps120001
(title: "cleanup, consistency, comments, clone fix")

[commit-bot: I haz the power, 2017-04-21 18:07:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 18:19:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 18:19:40]

Try jobs failed on following builders:
  Luci-go Win Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/35aa891d20ab7c10)

[dnj, 2017-04-21 18:36:17]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-04-21 18:36:17]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2833073004/#ps140001
(title: "fix test")

[commit-bot: I haz the power, 2017-04-21 18:36:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 18:51:56]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1492799777173700,
"parent_rev": "49eca9e65f27839752cf6d678ad33e860f3fdfc1", "commit_rev":
"fde97cf33c7fad766b10ad40b5cbc10830d5749f"}

[commit-bot: I haz the power, 2017-04-21 18:51:59]

Description was changed from

==========
environ: Fix key case, add GetEmpty and Remove.

The "environ" package does not ignore the case of enviornment variable
keys on Windows. This patch fixes this bug by allowing an Env to be
configured to be case insensitive, and having Windows systems default to
"true".

Creation methods "System" and "New" will both default to the case
sensitivity of the current operating system.

Additionally, this patch adds Remove, which allows for the deletion of
enviornment variables, and GetEmpty, which offers an interface similar
to "os.Getenv".

BUG=chromium:714165
TEST=unit
==========

to

==========
environ: Fix key case, add GetEmpty and Remove.

The "environ" package does not ignore the case of enviornment variable
keys on Windows. This patch fixes this bug by allowing an Env to be
configured to be case insensitive, and having Windows systems default to
"true".

Creation methods "System" and "New" will both default to the case
sensitivity of the current operating system.

Additionally, this patch adds Remove, which allows for the deletion of
enviornment variables, and GetEmpty, which offers an interface similar
to "os.Getenv".

BUG=chromium:714165
TEST=unit

Review-Url: https://codereview.chromium.org/2833073004
Committed:
https://github.com/luci/luci-go/commit/fde97cf33c7fad766b10ad40b5cbc10830d5749f
==========

[commit-bot: I haz the power, 2017-04-21 18:52:00]

Committed patchset #8 (id:140001) as
https://github.com/luci/luci-go/commit/fde97cf33c7fad766b10ad40b5cbc10830d5749f