Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2833073002: Stoppp using trippple consonants (Closed)

Created:
3 years, 8 months ago by erikcorry
Modified:
3 years, 8 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org, dart-fe-team+reviews_google.com, Cutch, dart-uxr+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : annnotated #

Patch Set 3 : I before E except after C #

Patch Set 4 : More spolling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -90 lines) Patch
M build/config/win/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M build/gn_run_binary.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M docs/language/informal/covariant-from-class.md View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/CHANGELOG.md View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/html/dart2js/html_dart2js.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/isolate_helper.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/messages.yaml View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/parser/parser_suite.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/scanner/scanner_suite.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/DeltaBlue.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/pkg.status View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/testing/README.md View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/testing/lib/dart_vm_suite.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/eventhandler_win.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/reference_counting.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/convert_patch.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/code_view.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/pause_on_unhandled_async_exceptions2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/pause_on_unhandled_async_exceptions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/pause_on_unhandled_exceptions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/service_test_common.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/exceptions.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_allocator.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/redundancy_elimination.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M samples-dev/swarm/DataSource.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples-dev/swarm/appengine/main.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/isolate_helper.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_rti.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/js/dartium/js_dartium.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_equals_test.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_substitution_test.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib/string_replace_all_test.dart View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M tests/corelib/string_replace_test.dart View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M tests/corelib/string_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/string_replace_all_test.dart View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M tests/corelib_strong/string_replace_test.dart View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M tests/corelib_strong/string_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/html/js_typed_interop_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/html/svgelement_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/closure_parameter_types_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/language/library_env_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/closure_parameter_types_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/html/svgelement_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/bots/linux_distribution_support.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/docs/docs.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/configurations_xcode.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/task_kill.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
erikcorry
3 years, 8 months ago (2017-04-21 10:26:01 UTC) #1
ahe
lgtm
3 years, 8 months ago (2017-04-21 15:00:18 UTC) #2
erikcorry
3 years, 8 months ago (2017-04-21 15:50:21 UTC) #4
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
4b9bba55b410f4b41a30c08e8453d8033cb16c69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698