Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: runtime/observatory/lib/src/elements/code_view.dart

Issue 2833073002: Stoppp using trippple consonants (Closed)
Patch Set: More spolling Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/lib/convert_patch.dart ('k') | runtime/observatory/lib/src/service/object.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library code_view_element; 5 library code_view_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:html'; 8 import 'dart:html';
9 import 'package:observatory/cpu_profile.dart'; 9 import 'package:observatory/cpu_profile.dart';
10 import 'package:observatory/service.dart' as S; 10 import 'package:observatory/service.dart' as S;
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 } 422 }
423 var tick = code.profile.addressTicks[instruction.address]; 423 var tick = code.profile.addressTicks[instruction.address];
424 if (tick == null) { 424 if (tick == null) {
425 return ''; 425 return '';
426 } 426 }
427 var pcent = Utils.formatPercent( 427 var pcent = Utils.formatPercent(
428 tick.exclusiveTicks, code.profile.profile.sampleCount); 428 tick.exclusiveTicks, code.profile.profile.sampleCount);
429 return '$pcent (${tick.exclusiveTicks})'; 429 return '$pcent (${tick.exclusiveTicks})';
430 } 430 }
431 431
432 void _updateDiasssemblyTable() { 432 void _updateDisassemblyTable() {
433 S.Code code = _code as S.Code; 433 S.Code code = _code as S.Code;
434 disassemblyTable.clearRows(); 434 disassemblyTable.clearRows();
435 if (code == null) { 435 if (code == null) {
436 return; 436 return;
437 } 437 }
438 for (S.CodeInstruction instruction in code.instructions) { 438 for (S.CodeInstruction instruction in code.instructions) {
439 var row = [ 439 var row = [
440 _formattedAddress(instruction), 440 _formattedAddress(instruction),
441 _formattedInclusive(instruction), 441 _formattedInclusive(instruction),
442 _formattedExclusive(instruction), 442 _formattedExclusive(instruction),
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
523 // Fill table. 523 // Fill table.
524 var i = 0; 524 var i = 0;
525 for (var tr in tableBody.children) { 525 for (var tr in tableBody.children) {
526 var rowIndex = disassemblyTable.sortedRows[i]; 526 var rowIndex = disassemblyTable.sortedRows[i];
527 _fillDisassemblyDOMRow(tr, rowIndex); 527 _fillDisassemblyDOMRow(tr, rowIndex);
528 i++; 528 i++;
529 } 529 }
530 } 530 }
531 531
532 void _updateDisassembly() { 532 void _updateDisassembly() {
533 _updateDiasssemblyTable(); 533 _updateDisassemblyTable();
534 _updateDisassemblyDOMTable(); 534 _updateDisassemblyDOMTable();
535 } 535 }
536 536
537 void _updateInlineTable() { 537 void _updateInlineTable() {
538 inlineTable.clearRows(); 538 inlineTable.clearRows();
539 S.Code code = _code as S.Code; 539 S.Code code = _code as S.Code;
540 for (S.CodeInlineInterval interval in code.inlineIntervals) { 540 for (S.CodeInlineInterval interval in code.inlineIntervals) {
541 var row = [ 541 var row = [
542 interval, 542 interval,
543 _formattedInclusiveInterval(interval), 543 _formattedInclusiveInterval(interval),
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
640 case M.CodeKind.stub: 640 case M.CodeKind.stub:
641 return 'stub'; 641 return 'stub';
642 case M.CodeKind.tag: 642 case M.CodeKind.tag:
643 return 'tag'; 643 return 'tag';
644 case M.CodeKind.collected: 644 case M.CodeKind.collected:
645 return 'collected'; 645 return 'collected';
646 } 646 }
647 throw new Exception('Unkown CodeKind ($kind)'); 647 throw new Exception('Unkown CodeKind ($kind)');
648 } 648 }
649 } 649 }
OLDNEW
« no previous file with comments | « runtime/lib/convert_patch.dart ('k') | runtime/observatory/lib/src/service/object.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698