[DMC #1.93] Make DocumentMarkerController::AddMarker() take a pointer instead of a const ref

Make DocumentMarkerController::AddMarker() take a pointer instead of a const ref

Right now this method can take a const reference despite DMC possibly later
needing to edit the marker because the current implementation always copies the
marker (to construct a RenderedDocumentMarker). However, this is not guaranteed
by the API, and will be changed in the future once we no longer construct
RenderedDocumentMarkers for all MarkerTypes. So this method needs to be changed
to take a non-const pointer (could use a ref but I think doing so is discouraged
by the style guide). Also, the methods that call AddMarker() need to pass
pointers to heap-allocated objects.

BUG=707867
Review-Url: https://codereview.chromium.org/2833043002
Cr-Commit-Position: refs/heads/master@{#466596}
Committed: https://chromium.googlesource.com/chromium/src/+/9ad9f6860b4d6a4ec7f7f975b2c99672e02d5d49

[rlanday, 2017-04-21 08:15:18]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[rlanday, 2017-04-21 08:15:26]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 08:15:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 09:59:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 09:59:53]

Dry run: This issue passed the CQ dry run.

[rlanday, 2017-04-23 19:59:52]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-23 20:00:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-23 21:28:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-23 21:28:20]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-04-24 04:05:45]

lgtm

[rlanday, 2017-04-24 06:00:51]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-04-24 06:00:51]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2833043002/#ps40001
(title: "Remove dep")

[commit-bot: I haz the power, 2017-04-24 06:00:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 08:30:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493013651493040,
"parent_rev": "1acec704218435529ddfb9fd59295177129e036e", "commit_rev":
"9ad9f6860b4d6a4ec7f7f975b2c99672e02d5d49"}

[commit-bot: I haz the power, 2017-04-24 08:30:58]

Description was changed from

==========
Make DocumentMarkerController::AddMarker() take a pointer instead of a const ref

Right now this method can take a const reference despite DMC possibly later
needing to edit the marker because the current implementation always copies the
marker (to construct a RenderedDocumentMarker). However, this is not guaranteed
by the API, and will be changed in the future once we no longer construct
RenderedDocumentMarkers for all MarkerTypes. So this method needs to be changed
to take a non-const pointer (could use a ref but I think doing so is discouraged
by the style guide). Also, the methods that call AddMarker() need to pass
pointers to heap-allocated objects.

BUG=707867
==========

to

==========
Make DocumentMarkerController::AddMarker() take a pointer instead of a const ref

Right now this method can take a const reference despite DMC possibly later
needing to edit the marker because the current implementation always copies the
marker (to construct a RenderedDocumentMarker). However, this is not guaranteed
by the API, and will be changed in the future once we no longer construct
RenderedDocumentMarkers for all MarkerTypes. So this method needs to be changed
to take a non-const pointer (could use a ref but I think doing so is discouraged
by the style guide). Also, the methods that call AddMarker() need to pass
pointers to heap-allocated objects.

BUG=707867

Review-Url: https://codereview.chromium.org/2833043002
Cr-Commit-Position: refs/heads/master@{#466596}
Committed:
https://chromium.googlesource.com/chromium/src/+/9ad9f6860b4d6a4ec7f7f975b2c9...
==========

[commit-bot: I haz the power, 2017-04-24 08:31:00]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9ad9f6860b4d6a4ec7f7f975b2c9...