Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2833033002: Comment out asserts in WritableStream.js (Closed)

Created:
3 years, 8 months ago by Adam Rice
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Comment out asserts in WritableStream.js assert() statements can have a major performance impact, so comment them out. They have not been removed completely as they can be easily re-enabled for debugging purposes, and are also useful as documentation. BUG=709832 Review-Url: https://codereview.chromium.org/2818963002 Cr-Commit-Position: refs/heads/master@{#465538} (cherry picked from commit 8ac2349b4fc1649f4fef0a69de517ad74acabc10) Review-Url: https://codereview.chromium.org/2833033002 . Cr-Commit-Position: refs/branch-heads/3071@{#116} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/f752fdbc7771c9fe61146f8f6c34c987f18430de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -144 lines) Patch
M third_party/WebKit/Source/core/streams/WritableStream.js View 29 chunks +122 lines, -144 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Adam Rice
3 years, 8 months ago (2017-04-21 07:51:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f752fdbc7771c9fe61146f8f6c34c987f18430de.

Powered by Google App Engine
This is Rietveld 408576698