Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2833012: Move all system includes in vboot_firmware to sysincludes.h (Closed)

Created:
10 years, 6 months ago by Randall Spangler
Modified:
9 years, 7 months ago
Reviewers:
vb, Bill Richardson
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://gitrw.chromium.org/vboot_reference.git
Visibility:
Public.

Description

Move all system includes in vboot_firmware to sysincludes.h This makes it much easier to port vboot_firmware to platforms (such as UEFI) which don't have the standard include files; only sysincludes.h needs to be altered.

Patch Set 1 #

Patch Set 2 : Oops, forgot the new header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -41 lines) Patch
M cgpt/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M utility/kernel_utility.cc View 1 chunk +1 line, -0 lines 0 comments Download
M vboot_firmware/include/boot_device.h View 1 chunk +1 line, -1 line 0 comments Download
M vboot_firmware/include/gbb_header.h View 1 chunk +1 line, -1 line 0 comments Download
M vboot_firmware/include/load_firmware_fw.h View 1 chunk +1 line, -1 line 0 comments Download
M vboot_firmware/include/load_kernel_fw.h View 1 chunk +1 line, -1 line 0 comments Download
M vboot_firmware/include/rollback_index.h View 1 chunk +3 lines, -1 line 0 comments Download
A vboot_firmware/include/sysincludes.h View 1 chunk +27 lines, -0 lines 0 comments Download
M vboot_firmware/include/tlcl.h View 1 chunk +1 line, -4 lines 0 comments Download
M vboot_firmware/include/utility.h View 1 chunk +1 line, -2 lines 0 comments Download
M vboot_firmware/lib/cgptlib/crc32.c View 1 chunk +0 lines, -1 line 0 comments Download
M vboot_firmware/lib/cgptlib/include/cgptlib.h View 1 chunk +1 line, -1 line 0 comments Download
M vboot_firmware/lib/cgptlib/include/cgptlib_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M vboot_firmware/lib/cgptlib/include/crc32.h View 1 chunk +1 line, -1 line 0 comments Download
M vboot_firmware/lib/cgptlib/include/gpt.h View 1 chunk +1 line, -1 line 0 comments Download
M vboot_firmware/lib/cryptolib/include/padding.h View 1 chunk +1 line, -1 line 0 comments Download
M vboot_firmware/lib/cryptolib/include/rsa.h View 1 chunk +1 line, -1 line 0 comments Download
M vboot_firmware/lib/cryptolib/include/sha.h View 1 chunk +1 line, -1 line 0 comments Download
M vboot_firmware/lib/cryptolib/rsa_utility.c View 1 chunk +1 line, -0 lines 0 comments Download
M vboot_firmware/lib/cryptolib/sha1.c View 1 chunk +0 lines, -3 lines 0 comments Download
M vboot_firmware/lib/include/stateful_util.h View 1 chunk +1 line, -4 lines 0 comments Download
M vboot_firmware/lib/include/tss_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M vboot_firmware/lib/include/vboot_common.h View 1 chunk +0 lines, -2 lines 0 comments Download
M vboot_firmware/lib/include/vboot_kernel.h View 1 chunk +0 lines, -2 lines 0 comments Download
M vboot_firmware/lib/include/vboot_struct.h View 1 chunk +1 line, -1 line 0 comments Download
M vboot_firmware/lib/rollback_index.c View 1 chunk +1 line, -3 lines 0 comments Download
M vboot_firmware/lib/stateful_util.c View 1 chunk +1 line, -3 lines 0 comments Download
M vboot_firmware/lib/vboot_kernel.c View 1 chunk +0 lines, -1 line 0 comments Download
M vboot_firmware/linktest/main.c View 1 chunk +0 lines, -1 line 0 comments Download
M vboot_firmware/stub/utility_stub.c View 1 chunk +1 line, -0 lines 0 comments Download
M vkernel/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
M vkernel/kernel_image.c View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Randall Spangler
10 years, 6 months ago (2010-06-16 20:41:05 UTC) #1
Bill Richardson
10 years, 6 months ago (2010-06-16 20:42:40 UTC) #2 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698