Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2832983003: Revert of GeoLocation: add support for GmsCore location provider (Closed)

Created:
3 years, 8 months ago by mattcary
Modified:
3 years, 8 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of GeoLocation: add support for GmsCore location provider (patchset #5 id:260001 of https://codereview.chromium.org/2809813002/ ) Reason for revert: crbug.com/714053 This CL apparently broke WebKit CTS geolocation tests. Original issue's description: > GeoLocation: add support for GmsCore location provider > > This CL adds LocationProviderGmsCore.java, an implementation > of LocationProviderFactory.LocationProvider interface using the > Google Play Services (GMS) provided location. > > The tests content/public/.../LocationProviderTest.java are removed > and instead a new pumped up one is added in device/geolocation, > doing what the previous one was doing and parameterized to try > other location provider APIs (was: android only, now: mock, > android and GMS core). > > > BUG=706014 > > Review-Url: https://codereview.chromium.org/2809813002 > Cr-Commit-Position: refs/heads/master@{#466239} > Committed: https://chromium.googlesource.com/chromium/src/+/638d9c4adea26e0f8a9d2e429546a44f5603b99c TBR=aelias@chromium.org,agrieve@chromium.org,jbudorick@chromium.org,reillyg@chromium.org,timvolodine@chromium.org,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=706014, 714053 Review-Url: https://codereview.chromium.org/2832983003 Cr-Commit-Position: refs/heads/master@{#466291} Committed: https://chromium.googlesource.com/chromium/src/+/4787220cd49fb3cfafd19473cb7fe307e67ad3d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -389 lines) Patch
M content/public/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A content/public/android/javatests/src/org/chromium/content/browser/LocationProviderTest.java View 1 chunk +72 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M device/BUILD.gn View 2 chunks +0 lines, -7 lines 0 comments Download
M device/geolocation/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M device/geolocation/android/java/src/org/chromium/device/geolocation/LocationProviderAdapter.java View 3 chunks +5 lines, -10 lines 0 comments Download
M device/geolocation/android/java/src/org/chromium/device/geolocation/LocationProviderAndroid.java View 8 chunks +21 lines, -23 lines 0 comments Download
M device/geolocation/android/java/src/org/chromium/device/geolocation/LocationProviderFactory.java View 3 chunks +6 lines, -9 lines 0 comments Download
D device/geolocation/android/java/src/org/chromium/device/geolocation/LocationProviderGmsCore.java View 1 chunk +0 lines, -136 lines 0 comments Download
M device/geolocation/android/javatests/src/org/chromium/device/geolocation/MockLocationProvider.java View 2 chunks +2 lines, -5 lines 0 comments Download
D device/geolocation/android/junit/src/org/chromium/device/geolocation/LocationProviderTest.java View 1 chunk +0 lines, -194 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
mattcary
Created Revert of GeoLocation: add support for GmsCore location provider
3 years, 8 months ago (2017-04-21 08:55:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832983003/1
3 years, 8 months ago (2017-04-21 08:55:19 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 08:56:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4787220cd49fb3cfafd19473cb7f...

Powered by Google App Engine
This is Rietveld 408576698