Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2832973003: Split net/spdy into core and chromium subdirectories. (Closed)

Created:
3 years, 8 months ago by Bence
Modified:
3 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, gavinp+disk_chromium.org, pkl (ping after 24h if needed), jam, Randy Smith (Not in Mondays), net-reviews_chromium.org, marq+watch_chromium.org, bnc+watch_chromium.org, darin-cc_chromium.org, loading-reviews_chromium.org, noyau+watch_chromium.org, fuzzing_chromium.org, mmenke, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Split net/spdy into core and chromium subdirectories. Create net/spdy/core for files (and subdirectories: hpack and fuzzer) that are shared with internal code. Create net/spdy/chromium for Chromium-specific source files. Leave platform and OWNERS at net/spdy level. This follows the pattern established in net/quic, and is going to make it possible to have presubmit checks for net/spdy/core that make it easier to maintain shared code. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2832973003 Cr-Commit-Position: refs/heads/master@{#466681} Committed: https://chromium.googlesource.com/chromium/src/+/8f8f7d30276c21106db2b65f176e999b592549ea

Patch Set 1 #

Patch Set 2 : Fix some more build rules. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+667 lines, -62871 lines) Patch
M components/cronet/android/cronet_bidirectional_stream_adapter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/grpc_support/bidirectional_stream.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/grpc_support/bidirectional_stream_c.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/grpc_support/test/quic_test_server.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/network_session_configurator/network_session_configurator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/network_session_configurator/network_session_configurator_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/netlog_observer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/netlog_observer_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M net/BUILD.gn View 1 8 chunks +156 lines, -156 lines 0 comments Download
M net/http/bidirectional_stream.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/bidirectional_stream_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_cache_lookup_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_layer.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/http_network_layer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_session.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_network_session.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_proxy_client_socket_wrapper.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket_wrapper.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M net/http/http_server_properties.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_stream_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_job.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_request.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_request.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_request_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M net/http2/hpack/decoder/hpack_decoder_string_buffer_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http2/hpack/huffman/http2_hpack_huffman_decoder_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http2/hpack/tools/hpack_block_builder_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http2/hpack/tools/hpack_example.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_http_stream.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_http_stream.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_http_stream_test.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/chromium/quic_http_utils.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_network_transaction_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_test_packet_maker.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_client_promised_info.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_header_list.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_headers_stream.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/core/quic_session_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_spdy_stream.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_write_blocked_list.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/spdy_utils.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/spdy_utils.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_spdy_session_peer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
D net/spdy/array_output_buffer.h View 1 1 chunk +0 lines, -45 lines 0 comments Download
D net/spdy/array_output_buffer.cc View 1 1 chunk +0 lines, -23 lines 0 comments Download
D net/spdy/array_output_buffer_test.cc View 1 1 chunk +0 lines, -49 lines 0 comments Download
D net/spdy/bidirectional_stream_spdy_impl.h View 1 1 chunk +0 lines, -136 lines 0 comments Download
D net/spdy/bidirectional_stream_spdy_impl.cc View 1 1 chunk +0 lines, -424 lines 0 comments Download
D net/spdy/bidirectional_stream_spdy_impl_unittest.cc View 1 1 chunk +0 lines, -520 lines 0 comments Download
D net/spdy/buffered_spdy_framer.h View 1 1 chunk +0 lines, -278 lines 0 comments Download
D net/spdy/buffered_spdy_framer.cc View 1 1 chunk +0 lines, -320 lines 0 comments Download
D net/spdy/buffered_spdy_framer_unittest.cc View 1 1 chunk +0 lines, -331 lines 0 comments Download
A + net/spdy/chromium/bidirectional_stream_spdy_impl.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + net/spdy/chromium/bidirectional_stream_spdy_impl.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + net/spdy/chromium/bidirectional_stream_spdy_impl_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + net/spdy/chromium/buffered_spdy_framer.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + net/spdy/chromium/buffered_spdy_framer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/buffered_spdy_framer_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/chromium/header_coalescer.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/chromium/header_coalescer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/header_coalescer_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/http2_priority_dependencies.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/http2_priority_dependencies.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/http2_priority_dependencies_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/multiplexed_http_stream.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/multiplexed_http_stream.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/multiplexed_session.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/chromium/multiplexed_session.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/server_push_delegate.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/chromium/spdy_buffer.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/chromium/spdy_buffer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + net/spdy/chromium/spdy_buffer_producer.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/chromium/spdy_buffer_producer.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + net/spdy/chromium/spdy_buffer_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + net/spdy/chromium/spdy_flags.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/chromium/spdy_flags.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/spdy_http_stream.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + net/spdy/chromium/spdy_http_stream.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + net/spdy/chromium/spdy_http_stream_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + net/spdy/chromium/spdy_http_utils.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + net/spdy/chromium/spdy_http_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/spdy_http_utils_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + net/spdy/chromium/spdy_log_util.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/spdy_log_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/spdy_log_util_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/spdy_network_transaction_unittest.cc View 1 1 chunk +8 lines, -8 lines 0 comments Download
A + net/spdy/chromium/spdy_proxy_client_socket.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + net/spdy/chromium/spdy_proxy_client_socket.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + net/spdy/chromium/spdy_proxy_client_socket_unittest.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + net/spdy/chromium/spdy_read_queue.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/chromium/spdy_read_queue.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/chromium/spdy_read_queue_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + net/spdy/chromium/spdy_session.h View 1 1 chunk +12 lines, -12 lines 0 comments Download
A + net/spdy/chromium/spdy_session.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
A + net/spdy/chromium/spdy_session_fuzzer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/spdy_session_key.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/chromium/spdy_session_key.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/spdy_session_pool.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + net/spdy/chromium/spdy_session_pool.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + net/spdy/chromium/spdy_session_pool_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + net/spdy/chromium/spdy_session_test_util.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/chromium/spdy_session_test_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/spdy_session_unittest.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
A + net/spdy/chromium/spdy_stream.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + net/spdy/chromium/spdy_stream.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + net/spdy/chromium/spdy_stream_test_util.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/chromium/spdy_stream_test_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/chromium/spdy_stream_unittest.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
A + net/spdy/chromium/spdy_test_util_common.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/spdy_test_util_common.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
A + net/spdy/chromium/spdy_write_queue.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/chromium/spdy_write_queue.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + net/spdy/chromium/spdy_write_queue_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + net/spdy/core/array_output_buffer.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/array_output_buffer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/array_output_buffer_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/fuzzing/hpack_example_generator.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + net/spdy/core/fuzzing/hpack_fuzz_util.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/core/fuzzing/hpack_fuzz_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/core/fuzzing/hpack_fuzz_util_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + net/spdy/core/hpack/hpack_constants.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/core/hpack/hpack_constants.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + net/spdy/core/hpack/hpack_decoder.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + net/spdy/core/hpack/hpack_decoder.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + net/spdy/core/hpack/hpack_decoder3.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + net/spdy/core/hpack/hpack_decoder3.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/core/hpack/hpack_decoder3_test.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
A + net/spdy/core/hpack/hpack_decoder_interface.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + net/spdy/core/hpack/hpack_decoder_test.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
A + net/spdy/core/hpack/hpack_encoder.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + net/spdy/core/hpack/hpack_encoder.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + net/spdy/core/hpack/hpack_encoder_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/core/hpack/hpack_entry.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/core/hpack/hpack_entry.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/hpack/hpack_entry_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/hpack/hpack_header_table.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/hpack/hpack_header_table.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + net/spdy/core/hpack/hpack_header_table_test.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + net/spdy/core/hpack/hpack_huffman_decoder.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/hpack/hpack_huffman_decoder.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + net/spdy/core/hpack/hpack_huffman_decoder_test.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + net/spdy/core/hpack/hpack_huffman_table.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/hpack/hpack_huffman_table.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + net/spdy/core/hpack/hpack_huffman_table_test.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + net/spdy/core/hpack/hpack_input_stream.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/core/hpack/hpack_input_stream.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + net/spdy/core/hpack/hpack_input_stream_test.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + net/spdy/core/hpack/hpack_output_stream.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/hpack/hpack_output_stream.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/hpack/hpack_output_stream_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/hpack/hpack_round_trip_test.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + net/spdy/core/hpack/hpack_static_table.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/hpack/hpack_static_table.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + net/spdy/core/hpack/hpack_static_table_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/core/http2_frame_decoder_adapter.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/core/http2_frame_decoder_adapter.cc View 1 2 chunks +9 lines, -9 lines 0 comments Download
A + net/spdy/core/lifo_write_scheduler.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/lifo_write_scheduler_test.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + net/spdy/core/mock_spdy_framer_visitor.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/core/mock_spdy_framer_visitor.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/priority_write_scheduler.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + net/spdy/core/priority_write_scheduler_test.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + net/spdy/core/spdy_alt_svc_wire_format.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/core/spdy_alt_svc_wire_format.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/spdy_alt_svc_wire_format_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/spdy_bitmasks.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/core/spdy_bug_tracker.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/core/spdy_deframer_visitor.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + net/spdy/core/spdy_deframer_visitor.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
A + net/spdy/core/spdy_deframer_visitor_test.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
A + net/spdy/core/spdy_frame_builder.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + net/spdy/core/spdy_frame_builder.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + net/spdy/core/spdy_frame_builder_test.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + net/spdy/core/spdy_frame_reader.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/core/spdy_frame_reader.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/core/spdy_frame_reader_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/spdy_framer.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
A + net/spdy/core/spdy_framer.cc View 1 2 chunks +11 lines, -11 lines 0 comments Download
A + net/spdy/core/spdy_framer_decoder_adapter.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + net/spdy/core/spdy_framer_decoder_adapter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/spdy_framer_test.cc View 1 2 chunks +9 lines, -9 lines 0 comments Download
A + net/spdy/core/spdy_header_block.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/core/spdy_header_block.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/spdy_header_block_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/core/spdy_header_indexing.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/core/spdy_header_indexing.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/core/spdy_header_indexing_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/spdy_headers_handler_interface.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/core/spdy_no_op_visitor.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/core/spdy_no_op_visitor.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/spdy_pinnable_buffer_piece.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + net/spdy/core/spdy_pinnable_buffer_piece.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/spdy_pinnable_buffer_piece_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/core/spdy_prefixed_buffer_reader.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/spdy_prefixed_buffer_reader.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/spdy_prefixed_buffer_reader_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/spdy_protocol.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + net/spdy/core/spdy_protocol.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/core/spdy_protocol_test.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + net/spdy/core/spdy_protocol_test_utils.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + net/spdy/core/spdy_protocol_test_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/spdy_test_utils.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + net/spdy/core/spdy_test_utils.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + net/spdy/core/write_scheduler.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + net/spdy/core/zero_copy_output_buffer.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D net/spdy/fuzzing/hpack_example_generator.cc View 1 1 chunk +0 lines, -77 lines 0 comments Download
D net/spdy/fuzzing/hpack_fuzz_util.h View 1 1 chunk +0 lines, -95 lines 0 comments Download
D net/spdy/fuzzing/hpack_fuzz_util.cc View 1 1 chunk +0 lines, -190 lines 0 comments Download
D net/spdy/fuzzing/hpack_fuzz_util_test.cc View 1 1 chunk +0 lines, -147 lines 0 comments Download
D net/spdy/header_coalescer.h View 1 1 chunk +0 lines, -43 lines 0 comments Download
D net/spdy/header_coalescer.cc View 1 1 chunk +0 lines, -87 lines 0 comments Download
D net/spdy/header_coalescer_test.cc View 1 1 chunk +0 lines, -140 lines 0 comments Download
D net/spdy/hpack/hpack_constants.h View 1 1 chunk +0 lines, -93 lines 0 comments Download
D net/spdy/hpack/hpack_constants.cc View 1 1 chunk +0 lines, -415 lines 0 comments Download
D net/spdy/hpack/hpack_decoder.h View 1 1 chunk +0 lines, -155 lines 0 comments Download
D net/spdy/hpack/hpack_decoder.cc View 1 1 chunk +0 lines, -285 lines 0 comments Download
D net/spdy/hpack/hpack_decoder3.h View 1 1 chunk +0 lines, -131 lines 0 comments Download
D net/spdy/hpack/hpack_decoder3.cc View 1 1 chunk +0 lines, -198 lines 0 comments Download
D net/spdy/hpack/hpack_decoder3_test.cc View 1 1 chunk +0 lines, -1074 lines 0 comments Download
D net/spdy/hpack/hpack_decoder_interface.h View 1 1 chunk +0 lines, -76 lines 0 comments Download
D net/spdy/hpack/hpack_decoder_test.cc View 1 1 chunk +0 lines, -852 lines 0 comments Download
D net/spdy/hpack/hpack_encoder.h View 1 1 chunk +0 lines, -156 lines 0 comments Download
D net/spdy/hpack/hpack_encoder.cc View 1 1 chunk +0 lines, -371 lines 0 comments Download
D net/spdy/hpack/hpack_encoder_test.cc View 1 1 chunk +0 lines, -587 lines 0 comments Download
D net/spdy/hpack/hpack_entry.h View 1 1 chunk +0 lines, -109 lines 0 comments Download
D net/spdy/hpack/hpack_entry.cc View 1 1 chunk +0 lines, -89 lines 0 comments Download
D net/spdy/hpack/hpack_entry_test.cc View 1 1 chunk +0 lines, -122 lines 0 comments Download
D net/spdy/hpack/hpack_header_table.h View 1 1 chunk +0 lines, -177 lines 0 comments Download
D net/spdy/hpack/hpack_header_table.cc View 1 1 chunk +0 lines, -276 lines 0 comments Download
D net/spdy/hpack/hpack_header_table_test.cc View 1 1 chunk +0 lines, -448 lines 0 comments Download
D net/spdy/hpack/hpack_huffman_decoder.h View 1 1 chunk +0 lines, -67 lines 0 comments Download
D net/spdy/hpack/hpack_huffman_decoder.cc View 1 1 chunk +0 lines, -400 lines 0 comments Download
D net/spdy/hpack/hpack_huffman_decoder_test.cc View 1 1 chunk +0 lines, -255 lines 0 comments Download
D net/spdy/hpack/hpack_huffman_table.h View 1 1 chunk +0 lines, -134 lines 0 comments Download
D net/spdy/hpack/hpack_huffman_table.cc View 1 1 chunk +0 lines, -326 lines 0 comments Download
D net/spdy/hpack/hpack_huffman_table_test.cc View 1 1 chunk +0 lines, -466 lines 0 comments Download
D net/spdy/hpack/hpack_input_stream.h View 1 1 chunk +0 lines, -113 lines 0 comments Download
D net/spdy/hpack/hpack_input_stream.cc View 1 1 chunk +0 lines, -249 lines 0 comments Download
D net/spdy/hpack/hpack_input_stream_test.cc View 1 1 chunk +0 lines, -780 lines 0 comments Download
D net/spdy/hpack/hpack_output_stream.h View 1 1 chunk +0 lines, -78 lines 0 comments Download
D net/spdy/hpack/hpack_output_stream.cc View 1 1 chunk +0 lines, -97 lines 0 comments Download
D net/spdy/hpack/hpack_output_stream_test.cc View 1 1 chunk +0 lines, -276 lines 0 comments Download
D net/spdy/hpack/hpack_round_trip_test.cc View 1 1 chunk +0 lines, -229 lines 0 comments Download
D net/spdy/hpack/hpack_static_table.h View 1 1 chunk +0 lines, -56 lines 0 comments Download
D net/spdy/hpack/hpack_static_table.cc View 1 1 chunk +0 lines, -50 lines 0 comments Download
D net/spdy/hpack/hpack_static_table_test.cc View 1 1 chunk +0 lines, -60 lines 0 comments Download
D net/spdy/http2_frame_decoder_adapter.h View 1 1 chunk +0 lines, -24 lines 0 comments Download
D net/spdy/http2_frame_decoder_adapter.cc View 1 1 chunk +0 lines, -1001 lines 0 comments Download
D net/spdy/http2_priority_dependencies.h View 1 1 chunk +0 lines, -90 lines 0 comments Download
D net/spdy/http2_priority_dependencies.cc View 1 1 chunk +0 lines, -167 lines 0 comments Download
D net/spdy/http2_priority_dependencies_unittest.cc View 1 1 chunk +0 lines, -260 lines 0 comments Download
D net/spdy/lifo_write_scheduler.h View 1 1 chunk +0 lines, -183 lines 0 comments Download
D net/spdy/lifo_write_scheduler_test.cc View 1 1 chunk +0 lines, -146 lines 0 comments Download
D net/spdy/mock_spdy_framer_visitor.h View 1 1 chunk +0 lines, -104 lines 0 comments Download
D net/spdy/mock_spdy_framer_visitor.cc View 1 1 chunk +0 lines, -19 lines 0 comments Download
D net/spdy/multiplexed_http_stream.h View 1 1 chunk +0 lines, -39 lines 0 comments Download
D net/spdy/multiplexed_http_stream.cc View 1 1 chunk +0 lines, -59 lines 0 comments Download
D net/spdy/multiplexed_session.h View 1 1 chunk +0 lines, -78 lines 0 comments Download
D net/spdy/multiplexed_session.cc View 1 1 chunk +0 lines, -51 lines 0 comments Download
D net/spdy/priority_write_scheduler.h View 1 1 chunk +0 lines, -298 lines 0 comments Download
D net/spdy/priority_write_scheduler_test.cc View 1 1 chunk +0 lines, -376 lines 0 comments Download
D net/spdy/server_push_delegate.h View 1 1 chunk +0 lines, -39 lines 0 comments Download
D net/spdy/spdy_alt_svc_wire_format.h View 1 1 chunk +0 lines, -87 lines 0 comments Download
D net/spdy/spdy_alt_svc_wire_format.cc View 1 1 chunk +0 lines, -357 lines 0 comments Download
D net/spdy/spdy_alt_svc_wire_format_test.cc View 1 1 chunk +0 lines, -553 lines 0 comments Download
D net/spdy/spdy_bitmasks.h View 1 1 chunk +0 lines, -27 lines 0 comments Download
D net/spdy/spdy_buffer.h View 1 1 chunk +0 lines, -108 lines 0 comments Download
D net/spdy/spdy_buffer.cc View 1 1 chunk +0 lines, -117 lines 0 comments Download
D net/spdy/spdy_buffer_producer.h View 1 1 chunk +0 lines, -56 lines 0 comments Download
D net/spdy/spdy_buffer_producer.cc View 1 1 chunk +0 lines, -34 lines 0 comments Download
D net/spdy/spdy_buffer_unittest.cc View 1 1 chunk +0 lines, -135 lines 0 comments Download
D net/spdy/spdy_bug_tracker.h View 1 1 chunk +0 lines, -14 lines 0 comments Download
D net/spdy/spdy_deframer_visitor.h View 1 1 chunk +0 lines, -250 lines 0 comments Download
D net/spdy/spdy_deframer_visitor.cc View 1 1 chunk +0 lines, -1025 lines 0 comments Download
D net/spdy/spdy_deframer_visitor_test.cc View 1 1 chunk +0 lines, -271 lines 0 comments Download
D net/spdy/spdy_flags.h View 1 1 chunk +0 lines, -22 lines 0 comments Download
D net/spdy/spdy_flags.cc View 1 1 chunk +0 lines, -25 lines 0 comments Download
D net/spdy/spdy_frame_builder.h View 1 1 chunk +0 lines, -168 lines 0 comments Download
D net/spdy/spdy_frame_builder.cc View 1 1 chunk +0 lines, -280 lines 0 comments Download
D net/spdy/spdy_frame_builder_test.cc View 1 1 chunk +0 lines, -66 lines 0 comments Download
D net/spdy/spdy_frame_reader.h View 1 1 chunk +0 lines, -130 lines 0 comments Download
D net/spdy/spdy_frame_reader.cc View 1 1 chunk +0 lines, -206 lines 0 comments Download
D net/spdy/spdy_frame_reader_test.cc View 1 1 chunk +0 lines, -251 lines 0 comments Download
D net/spdy/spdy_framer.h View 1 1 chunk +0 lines, -957 lines 0 comments Download
D net/spdy/spdy_framer.cc View 1 1 chunk +0 lines, -2958 lines 0 comments Download
D net/spdy/spdy_framer_decoder_adapter.h View 1 1 chunk +0 lines, -168 lines 0 comments Download
D net/spdy/spdy_framer_decoder_adapter.cc View 1 1 chunk +0 lines, -251 lines 0 comments Download
D net/spdy/spdy_framer_test.cc View 1 1 chunk +0 lines, -4831 lines 0 comments Download
D net/spdy/spdy_header_block.h View 1 1 chunk +0 lines, -260 lines 0 comments Download
D net/spdy/spdy_header_block.cc View 1 1 chunk +0 lines, -399 lines 0 comments Download
D net/spdy/spdy_header_block_test.cc View 1 1 chunk +0 lines, -223 lines 0 comments Download
D net/spdy/spdy_header_indexing.h View 1 1 chunk +0 lines, -71 lines 0 comments Download
D net/spdy/spdy_header_indexing.cc View 1 1 chunk +0 lines, -176 lines 0 comments Download
D net/spdy/spdy_header_indexing_test.cc View 1 1 chunk +0 lines, -124 lines 0 comments Download
D net/spdy/spdy_headers_handler_interface.h View 1 1 chunk +0 lines, -46 lines 0 comments Download
D net/spdy/spdy_http_stream.h View 1 1 chunk +0 lines, -208 lines 0 comments Download
D net/spdy/spdy_http_stream.cc View 1 1 chunk +0 lines, -595 lines 0 comments Download
D net/spdy/spdy_http_stream_unittest.cc View 1 1 chunk +0 lines, -1070 lines 0 comments Download
D net/spdy/spdy_http_utils.h View 1 1 chunk +0 lines, -54 lines 0 comments Download
D net/spdy/spdy_http_utils.cc View 1 1 chunk +0 lines, -169 lines 0 comments Download
D net/spdy/spdy_http_utils_unittest.cc View 1 1 chunk +0 lines, -99 lines 0 comments Download
D net/spdy/spdy_log_util.h View 1 1 chunk +0 lines, -35 lines 0 comments Download
D net/spdy/spdy_log_util.cc View 1 1 chunk +0 lines, -40 lines 0 comments Download
D net/spdy/spdy_log_util_unittest.cc View 1 1 chunk +0 lines, -45 lines 0 comments Download
D net/spdy/spdy_network_transaction_unittest.cc View 1 1 chunk +0 lines, -6643 lines 0 comments Download
D net/spdy/spdy_no_op_visitor.h View 1 1 chunk +0 lines, -90 lines 0 comments Download
D net/spdy/spdy_no_op_visitor.cc View 1 1 chunk +0 lines, -29 lines 0 comments Download
D net/spdy/spdy_pinnable_buffer_piece.h View 1 1 chunk +0 lines, -59 lines 0 comments Download
D net/spdy/spdy_pinnable_buffer_piece.cc View 1 1 chunk +0 lines, -34 lines 0 comments Download
D net/spdy/spdy_pinnable_buffer_piece_test.cc View 1 1 chunk +0 lines, -79 lines 0 comments Download
D net/spdy/spdy_prefixed_buffer_reader.h View 1 1 chunk +0 lines, -43 lines 0 comments Download
D net/spdy/spdy_prefixed_buffer_reader.cc View 1 1 chunk +0 lines, -83 lines 0 comments Download
D net/spdy/spdy_prefixed_buffer_reader_test.cc View 1 1 chunk +0 lines, -131 lines 0 comments Download
D net/spdy/spdy_protocol.h View 1 1 chunk +0 lines, -926 lines 0 comments Download
D net/spdy/spdy_protocol.cc View 1 1 chunk +0 lines, -388 lines 0 comments Download
D net/spdy/spdy_protocol_test.cc View 1 1 chunk +0 lines, -258 lines 0 comments Download
D net/spdy/spdy_protocol_test_utils.h View 1 1 chunk +0 lines, -159 lines 0 comments Download
D net/spdy/spdy_protocol_test_utils.cc View 1 1 chunk +0 lines, -192 lines 0 comments Download
D net/spdy/spdy_proxy_client_socket.h View 1 1 chunk +0 lines, -189 lines 0 comments Download
D net/spdy/spdy_proxy_client_socket.cc View 1 1 chunk +0 lines, -534 lines 0 comments Download
D net/spdy/spdy_proxy_client_socket_unittest.cc View 1 1 chunk +0 lines, -1364 lines 0 comments Download
D net/spdy/spdy_read_queue.h View 1 1 chunk +0 lines, -53 lines 0 comments Download
D net/spdy/spdy_read_queue.cc View 1 1 chunk +0 lines, -59 lines 0 comments Download
D net/spdy/spdy_read_queue_unittest.cc View 1 1 chunk +0 lines, -140 lines 0 comments Download
D net/spdy/spdy_session.h View 1 1 chunk +0 lines, -1236 lines 0 comments Download
D net/spdy/spdy_session.cc View 1 1 chunk +0 lines, -3202 lines 0 comments Download
D net/spdy/spdy_session_fuzzer.cc View 1 1 chunk +0 lines, -96 lines 0 comments Download
D net/spdy/spdy_session_key.h View 1 1 chunk +0 lines, -63 lines 0 comments Download
D net/spdy/spdy_session_key.cc View 1 1 chunk +0 lines, -58 lines 0 comments Download
D net/spdy/spdy_session_pool.h View 1 1 chunk +0 lines, -261 lines 0 comments Download
D net/spdy/spdy_session_pool.cc View 1 1 chunk +0 lines, -514 lines 0 comments Download
D net/spdy/spdy_session_pool_unittest.cc View 1 1 chunk +0 lines, -909 lines 0 comments Download
D net/spdy/spdy_session_test_util.h View 1 1 chunk +0 lines, -46 lines 0 comments Download
D net/spdy/spdy_session_test_util.cc View 1 1 chunk +0 lines, -37 lines 0 comments Download
D net/spdy/spdy_session_unittest.cc View 1 1 chunk +0 lines, -6109 lines 0 comments Download
D net/spdy/spdy_stream.h View 1 1 chunk +0 lines, -533 lines 0 comments Download
D net/spdy/spdy_stream.cc View 1 1 chunk +0 lines, -930 lines 0 comments Download
D net/spdy/spdy_stream_test_util.h View 1 1 chunk +0 lines, -140 lines 0 comments Download
D net/spdy/spdy_stream_test_util.cc View 1 1 chunk +0 lines, -165 lines 0 comments Download
D net/spdy/spdy_stream_unittest.cc View 1 1 chunk +0 lines, -1560 lines 0 comments Download
D net/spdy/spdy_test_util_common.h View 1 1 chunk +0 lines, -547 lines 0 comments Download
D net/spdy/spdy_test_util_common.cc View 1 1 chunk +0 lines, -1170 lines 0 comments Download
D net/spdy/spdy_test_utils.h View 1 1 chunk +0 lines, -115 lines 0 comments Download
D net/spdy/spdy_test_utils.cc View 1 1 chunk +0 lines, -184 lines 0 comments Download
D net/spdy/spdy_write_queue.h View 1 1 chunk +0 lines, -97 lines 0 comments Download
D net/spdy/spdy_write_queue.cc View 1 1 chunk +0 lines, -167 lines 0 comments Download
D net/spdy/spdy_write_queue_unittest.cc View 1 1 chunk +0 lines, -381 lines 0 comments Download
D net/spdy/write_scheduler.h View 1 1 chunk +0 lines, -151 lines 0 comments Download
D net/spdy/zero_copy_output_buffer.h View 1 1 chunk +0 lines, -30 lines 0 comments Download
M net/test/net_test_suite.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client_bin.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_http_response_cache.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_http_response_cache.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_client.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_client_bin.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_stream.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_handshake_stream_create_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
Bence
Ryan: PTAL at net/, components/network_session_configurator/, and ios/. Misha: PTAL at components/cronet/ and components/grpc_support/. Charlie: PTAL ...
3 years, 8 months ago (2017-04-21 17:07:17 UTC) #10
Bence
Ryan: PTAL at net/, components/network_session_configurator/, and ios/. Misha: PTAL at components/cronet/ and components/grpc_support/. Charlie: PTAL ...
3 years, 8 months ago (2017-04-21 17:07:40 UTC) #11
Charlie Harrison
c/b/l LGTM
3 years, 8 months ago (2017-04-21 17:20:37 UTC) #12
Ryan Hamilton
lgtm
3 years, 8 months ago (2017-04-21 17:26:18 UTC) #13
mef
components/cronet and components/grpc_support lgtm
3 years, 8 months ago (2017-04-24 14:57:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832973003/10001
3 years, 8 months ago (2017-04-24 16:42:23 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 18:08:27 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:10001) as
https://chromium.googlesource.com/chromium/src/+/8f8f7d30276c21106db2b65f176e...

Powered by Google App Engine
This is Rietveld 408576698