third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl - Issue 2832923003: v8binding: Don't allow author script to define indexed accessor prop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

Issue 2832923003: v8binding: Don't allow author script to define indexed accessor prop. (Closed)

Patch Set: Added the test expectation. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/interface.h.tmpl ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

index c921f5d9da3c6e64aba33ecdae3153d6332695a8..3f7a0fa1cd8c2449bb7f956a99c1ed29763e3a36 100644

--- a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

@@ -244,6 +244,7 @@ static const struct {

{% block indexed_property_getter_callback %}{% endblock %}

{% block indexed_property_setter_callback %}{% endblock %}

{% block indexed_property_deleter_callback %}{% endblock %}

+{% block indexed_property_definer_callback %}{% endblock %}

{% if has_access_check_callbacks and not is_partial %}

bool {{v8_class_or_partial}}::securityCheck(v8::Local<v8::Context> accessingContext, v8::Local<v8::Object> accessedObject, v8::Local<v8::Value> data) {