third_party/WebKit/Source/bindings/templates/interface.h.tmpl - Issue 2832923003: v8binding: Don't allow author script to define indexed accessor prop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.h.tmpl

Issue 2832923003: v8binding: Don't allow author script to define indexed accessor prop. (Closed)

Patch Set: Added the test expectation. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/templates/interface.h.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/interface.h.tmpl b/third_party/WebKit/Source/bindings/templates/interface.h.tmpl

index b294016dcff209eb264cad91020db0f3afbb3376..d2b973511b00cf773a922cddec778b525f30a673 100644

--- a/third_party/WebKit/Source/bindings/templates/interface.h.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/interface.h.tmpl

@@ -245,12 +245,15 @@ class {{v8_class}} {

{% if indexed_property_getter or named_property_getter %}

{{exported}}static void indexedPropertyGetterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>&);

{% endif %}

- {% if indexed_property_setter or named_property_setter %}

+ {% if indexed_property_getter or named_property_setter %}

{{exported}}static void indexedPropertySetterCallback(uint32_t index, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<v8::Value>&);

{% endif %}

{% if indexed_property_deleter or named_property_deleter %}

{{exported}}static void indexedPropertyDeleterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Boolean>&);

{% endif %}

+ {% if indexed_property_getter %}

+ {{exported}}static void indexedPropertyDefinerCallback(uint32_t index, const v8::PropertyDescriptor&, const v8::PropertyCallbackInfo<v8::Value>&);

+ {% endif %}

{% if needs_runtime_enabled_installer %}

{{exported if has_partial_interface else ''}}static void InstallRuntimeEnabledFeatures(