fix #27971, implement generic function RTTI

fix #27971, implement generic function RTTI

R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/d26bb565756cd68f5f6af71b963951498a6d758a

[Jennifer Messerly, 2017-04-21 00:36:46]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[vsm, 2017-04-21 22:19:55]

lgtm

https://codereview.chromium.org/2832913003/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2832913003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:768: if
(typeFormals.isNotEmpty) {
Is this if not needed in the GenericTypeAliasElement case?

https://codereview.chromium.org/2832913003/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart (right):

https://codereview.chromium.org/2832913003/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart:463: // should
handle the functions generated by our compiler.
Should we be eventually encoding this in the type metadata?  I assume we'll need
to do that to record bounds anyway.

https://codereview.chromium.org/2832913003/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart:788: // and g2 ,
but it does not, see this issue:
Missing issue #?

[Jennifer Messerly, 2017-04-21 22:39:59]

Thank you!!!

Note also, 3 more tests pass when merged with this :D

https://codereview.chromium.org/2832913003/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2832913003/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:768: if
(typeFormals.isNotEmpty) {
On 2017/04/21 22:19:54, vsm wrote:
> Is this if not needed in the GenericTypeAliasElement case?

no it is not needed. GenericTypeAliasElement representation and how it tracks
type is different. I'm not sure which is better, and I would also like to see it
reconciled, but this is where we're at right now in Analyzer's element model.

https://codereview.chromium.org/2832913003/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart (right):

https://codereview.chromium.org/2832913003/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart:463: // should
handle the functions generated by our compiler.
On 2017/04/21 22:19:54, vsm wrote:
> Should we be eventually encoding this in the type metadata?  I assume we'll
need
> to do that to record bounds anyway.

yes quite possible. I need to cross that bridge when I get there, but thinking
along similar lines. :)

https://codereview.chromium.org/2832913003/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart:788: // and g2 ,
but it does not, see this issue:
On 2017/04/21 22:19:54, vsm wrote:
> Missing issue #?

Good catch, done!

[Jennifer Messerly, 2017-04-21 22:40:55]

Description was changed from

==========
fix #27971, implement generic function RTTI
==========

to

==========
fix #27971, implement generic function RTTI

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d26bb565756cd68f5f6af71b963951498a6d758a
==========

[Jennifer Messerly, 2017-04-21 22:40:56]

Committed patchset #2 (id:10001) manually as
d26bb565756cd68f5f6af71b963951498a6d758a.