fix #27971, implement generic function RTTI

pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// This library defines runtime operations on objects used by the code
 /// generator.
 part of dart._runtime;
 
 class InvocationImpl extends Invocation {
   final Symbol memberName;
@@ skipping 249 matching lines @@
     // TODO(leafp): Allow JS objects to go through?
     if ($typeArgs != null) {
       // TODO(jmesserly): is there a sensible way to handle these?
       $throwStrongModeError('call to JS object `' + $obj +
           '` with type arguments <' + $typeArgs + '> is not supported.');
     }
     return $f.apply($obj, $args);
   }
 
   // Apply type arguments
-  let formalCount = $ftype[$_typeFormalCount];
-  if (formalCount != null) {
+  if ($ftype instanceof $GenericFunctionType) {
+    let formalCount = $ftype.formalCount;
+    
     if ($typeArgs == null) {
+      // TODO(jmesserly): this should use instantiate to bounds logic.
+      // See https://github.com/dart-lang/sdk/issues/27256
       $typeArgs = Array(formalCount).fill($dynamic);
     } else if ($typeArgs.length != formalCount) {
       // TODO(jmesserly): is this the right error?
       $throwStrongModeError(
           'incorrect number of arguments to generic function ' +
           $typeName($ftype) + ', got <' + $typeArgs + '> expected ' +
           formalCount + '.');
     }
-    // Instantiate the function.
-    $ftype = $ftype.apply(null, $typeArgs);
+    // Instantiate the function type.
+    $ftype = $ftype.instantiate($typeArgs);
   } else if ($typeArgs != null) {
     $throwStrongModeError(
         'got type arguments to non-generic function ' + $typeName($ftype) +
         ', got <' + $typeArgs + '> expected none.');
   }
 
   if ($_checkApply($ftype, $args)) {
     if ($typeArgs != null) {
       return $f.apply($obj, $typeArgs).apply($obj, $args);
     }
@@ skipping 126 matching lines @@
       // Ignore if we would ignore either side of union.
       let typeArg = $getGenericArgs(type)[0];
       let typeFuture = ${getGenericClass(Future)}(typeArg);
       return $_ignoreTypeFailure(actual, typeFuture) ||
         $_ignoreTypeFailure(actual, typeArg);
     }
 
     if (!!$isSubtype(type, $Iterable) && !!$isSubtype(actual, $Iterable) ||
         !!$isSubtype(type, $Future) && !!$isSubtype(actual, $Future) ||
         !!$isSubtype(type, $Map) && !!$isSubtype(actual, $Map) ||
-        $isFunctionType(type) && $isFunctionType(actual) ||
+        $_isFunctionType(type) && $_isFunctionType(actual) ||
         !!$isSubtype(type, $Stream) && !!$isSubtype(actual, $Stream) ||
         !!$isSubtype(type, $StreamSubscription) &&
         !!$isSubtype(actual, $StreamSubscription)) {
       console.warn('Ignoring cast fail from ' + $typeName(actual) +
                    ' to ' + $typeName(type));
       return true;
     }
     return false;
   });
 })()''');
 
 /// Returns true if [obj] is an instance of [type]
 /// Returns true if [obj] is a JS function and [type] is a function type
 /// Returns false if [obj] is not an instance of [type] in both spec
 ///  and strong mode
 /// Returns null if [obj] is not an instance of [type] in strong mode
 ///  but might be in spec mode
 bool strongInstanceOf(obj, type, ignoreFromWhiteList) => JS(
     '',
     '''(() => {
   let actual = $getReifiedType($obj);
   let result = $isSubtype(actual, $type);
   if (result || (actual == $int && $isSubtype($double, $type))) return true;
-  if (actual == $jsobject && $isFunctionType(type) &&
+  if (actual == $jsobject && $_isFunctionType(type) &&
       typeof(obj) === 'function') {
     return true;
   }
   if (result === false) return false;
   if (!$_ignoreWhitelistedErrors || ($ignoreFromWhiteList == void 0)) return result;
   if ($_ignoreTypeFailure(actual, $type)) return true;
   return result;
 })()''');
 
 /// Returns true if [obj] is null or an instance of [type]
@@ skipping 469 matching lines @@
     name = '+' + name;
   }
   return name;
 }
 
 /// Emulates the implicit "loadLibrary" function provided by a deferred library.
 ///
 /// Libraries are not actually deferred in DDC, so this just returns a future
 /// that completes immediately.
 Future loadLibrary() => new Future.value();