Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2832873003: Add missing content quad element to native scene manager. (Closed)

Created:
3 years, 8 months ago by amp
Modified:
3 years, 8 months ago
Reviewers:
mthiesse
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Add missing content quad element to native scene manager. BUG=712343 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2826553002 Cr-Commit-Position: refs/heads/master@{#465273} (cherry picked from commit c434f0529beddf34dd85c99faf9e142ea094ce75) Review-Url: https://codereview.chromium.org/2832873003 Cr-Commit-Position: refs/branch-heads/3071@{#102} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/ce2f4af24a92d4251ce706c9b551f39a60d0f873

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/android/vr_shell/ui_scene_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
amp
Drover merge back to 59 (needs lgtm since I'm not a committer).
3 years, 8 months ago (2017-04-20 17:31:48 UTC) #3
mthiesse
3 years, 8 months ago (2017-04-20 21:39:15 UTC) #4
mthiesse
lgtm
3 years, 8 months ago (2017-04-20 21:39:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832873003/1
3 years, 8 months ago (2017-04-20 22:05:39 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 22:06:26 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ce2f4af24a92d4251ce706c9b551...

Powered by Google App Engine
This is Rietveld 408576698