Cleanup magic numbers in native scene manager

Cleanup magic numbers in native scene manager.

Also updates 2D quad properties to conform to spec.

BUG=643483
Review-Url: https://codereview.chromium.org/2832843004
Cr-Commit-Position: refs/heads/master@{#467749}
Committed: https://chromium.googlesource.com/chromium/src/+/7a4b49e0f05c61abe0ca8c1ef13fd252ff1c8b6c

[amp, 2017-04-20 18:35:23]

amp@chromium.org changed reviewers:
+ cjgrant@chromium.org, mthiesse@chromium.org

[amp, 2017-04-20 18:35:24]

Do we create bugs for simple cleanups like this?

[cjgrant, 2017-04-20 18:43:09]

On 2017/04/20 18:35:24, amp wrote:
> Do we create bugs for simple cleanups like this?

Michael will be posting a CL soon to tie these elements to Aldo's textures. 
This will conflict, so it'll either have to go onto the branch (in which case it
needs a bug), or you could hold off until after the warnings land.

As an example, Aldo made crbug/713779 for a text-related CL.  I don't know
whether umbrella-type bugs are okay in this case or not...

[amp, 2017-04-20 19:44:42]

On 2017/04/20 18:43:09, cjgrant wrote:
> On 2017/04/20 18:35:24, amp wrote:
> > Do we create bugs for simple cleanups like this?
> 
> Michael will be posting a CL soon to tie these elements to Aldo's textures. 
> This will conflict, so it'll either have to go onto the branch (in which case
it
> needs a bug), or you could hold off until after the warnings land.
> 
> As an example, Aldo made crbug/713779 for a text-related CL.  I don't know
> whether umbrella-type bugs are okay in this case or not...

I'll hold off until after we aren't going to merge anything back.  I just threw
this together per a comment Michael had on my size adjustments cl.

[amp, 2017-04-26 16:29:41]

On 2017/04/20 19:44:42, amp wrote:
> On 2017/04/20 18:43:09, cjgrant wrote:
> > On 2017/04/20 18:35:24, amp wrote:
> > > Do we create bugs for simple cleanups like this?
> > 
> > Michael will be posting a CL soon to tie these elements to Aldo's textures. 
> > This will conflict, so it'll either have to go onto the branch (in which
case
> it
> > needs a bug), or you could hold off until after the warnings land.
> > 
> > As an example, Aldo made crbug/713779 for a text-related CL.  I don't know
> > whether umbrella-type bugs are okay in this case or not...
> 
> I'll hold off until after we aren't going to merge anything back.  I just
threw
> this together per a comment Michael had on my size adjustments cl.

FYI I rebased against ToT and updated the height offset to match the latest UX
spec (-0.26 instead of -0.1).

Are we still merging things back to 59 or is this ok to potentially go in now?

[amp, 2017-04-26 23:43:25]

Description was changed from

==========
Cleanup magic numbers in native scene manager

BUG=
==========

to

==========
Cleanup magic numbers in native scene manager.

Also updates 2D quad properties to conform to spec.

BUG=643483
==========

[mthiesse, 2017-04-27 18:20:28]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2017-04-27 18:20:29]

lgtm

[mthiesse, 2017-04-27 18:20:52]

On 2017/04/26 16:29:41, amp wrote:
> On 2017/04/20 19:44:42, amp wrote:
> > On 2017/04/20 18:43:09, cjgrant wrote:
> > > On 2017/04/20 18:35:24, amp wrote:
> > > > Do we create bugs for simple cleanups like this?
> > > 
> > > Michael will be posting a CL soon to tie these elements to Aldo's
textures. 
> > > This will conflict, so it'll either have to go onto the branch (in which
> case
> > it
> > > needs a bug), or you could hold off until after the warnings land.
> > > 
> > > As an example, Aldo made crbug/713779 for a text-related CL.  I don't know
> > > whether umbrella-type bugs are okay in this case or not...
> > 
> > I'll hold off until after we aren't going to merge anything back.  I just
> threw
> > this together per a comment Michael had on my size adjustments cl.
> 
> FYI I rebased against ToT and updated the height offset to match the latest UX
> spec (-0.26 instead of -0.1).
> 
> Are we still merging things back to 59 or is this ok to potentially go in now?

Merge is a no-go, so this should go in now.

[commit-bot: I haz the power, 2017-04-27 18:21:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 19:14:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493317228520060,
"parent_rev": "bc74b94b7926f0322892fb5dd05d6c86194b13b9", "commit_rev":
"7a4b49e0f05c61abe0ca8c1ef13fd252ff1c8b6c"}

[commit-bot: I haz the power, 2017-04-27 19:14:59]

Description was changed from

==========
Cleanup magic numbers in native scene manager.

Also updates 2D quad properties to conform to spec.

BUG=643483
==========

to

==========
Cleanup magic numbers in native scene manager.

Also updates 2D quad properties to conform to spec.

BUG=643483

Review-Url: https://codereview.chromium.org/2832843004
Cr-Commit-Position: refs/heads/master@{#467749}
Committed:
https://chromium.googlesource.com/chromium/src/+/7a4b49e0f05c61abe0ca8c1ef13f...
==========

[commit-bot: I haz the power, 2017-04-27 19:15:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7a4b49e0f05c61abe0ca8c1ef13f...