Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2832843002: Fix call to `git cl status --field status` in wpt importer. (Closed)

Created:
3 years, 8 months ago by qyearsley
Modified:
3 years, 8 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix call to `git cl status --field status` in wpt importer. The latest import log reveals that this call is wrong, since the log contains: CL status: "Usage: git cl <command> [options]..." https://luci-milo.appspot.com/buildbot/chromium.infra.cron/wpt-importer/46 Review-Url: https://codereview.chromium.org/2832843002 Cr-Commit-Position: refs/heads/master@{#466262} Committed: https://chromium.googlesource.com/chromium/src/+/43f0c023623e0e1a3acd1d2ffc54d767218ae6d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
qyearsley
3 years, 8 months ago (2017-04-20 20:12:32 UTC) #2
jeffcarp
lgtm
3 years, 8 months ago (2017-04-20 23:39:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832843002/1
3 years, 8 months ago (2017-04-21 03:24:14 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 04:49:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/43f0c023623e0e1a3acd1d2ffc54...

Powered by Google App Engine
This is Rietveld 408576698