Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html

Issue 2832813002: Drop SiteBoundCredential in favor of CredentialUserData (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html
index 8d110b27a854b392db408d9eeb758651f8bf12e0..abda140795aeb6524c21284626563505b7d1d4b0 100644
--- a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html
+++ b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html
@@ -18,7 +18,7 @@
USVString iconURL;
Mike West 2017/04/24 07:34:08 Either in this patch or a subsequent patch, we sho
jdoerrie 2017/04/24 15:05:45 Done.
};
- interface SiteBoundCredential : Credential {
+ interface CredentialUserData {
Mike West 2017/04/24 07:34:08 Nit: Needs `NoInterfaceObject` + `SecureContext` a
jdoerrie 2017/04/24 15:05:45 Done.
readonly attribute USVString name;
readonly attribute USVString iconURL;
};
@@ -58,18 +58,20 @@
[Constructor(PasswordCredentialData data),
Constructor(HTMLFormElement form),
Exposed=Window]
- interface PasswordCredential : SiteBoundCredential {
+ interface PasswordCredential : Credential {
attribute USVString idName;
attribute USVString passwordName;
attribute CredentialBodyType? additionalData;
};
+ PasswordCredential implements CredentialUserData;
[Constructor(FederatedCredentialData data), Exposed=Window]
- interface FederatedCredential : SiteBoundCredential {
+ interface FederatedCredential : Credential {
readonly attribute USVString provider;
readonly attribute DOMString? protocol;
};
+ FederatedCredential implements CredentialUserData;
</script>
<script>
"use strict";

Powered by Google App Engine
This is Rietveld 408576698