third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html - Issue 2832813002: Drop SiteBoundCredential in favor of CredentialUserData

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl.html

Issue 2832813002: Drop SiteBoundCredential in favor of CredentialUserData (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/credentialmanager/idl-expected.txt » ('j') | third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src=/resources/testharness.js></script>	2 <script src=/resources/testharness.js></script>

3 <script src=/resources/testharnessreport.js></script>	3 <script src=/resources/testharnessreport.js></script>

4 <script src=/w3c/resources/WebIDLParser.js></script>	4 <script src=/w3c/resources/WebIDLParser.js></script>

5 <script src=/w3c/resources/idlharness.js></script>	5 <script src=/w3c/resources/idlharness.js></script>

6 <script type="text/plain" id="untested">	6 <script type="text/plain" id="untested">

7 dictionary CredentialData {	7 dictionary CredentialData {

8 USVString id;	8 USVString id;

9 };	9 };

10	10

11 interface Credential {	11 interface Credential {

12 readonly attribute USVString id;	12 readonly attribute USVString id;

13 readonly attribute DOMString type;	13 readonly attribute DOMString type;

14 };	14 };

15	15

16 dictionary SiteBoundCredentialData : CredentialData {	16 dictionary SiteBoundCredentialData : CredentialData {

17 USVString name;	17 USVString name;

18 USVString iconURL;	18 USVString iconURL;
	Mike West 2017/04/24 07:34:08 Either in this patch or a subsequent patch, we sho Either in this patch or a subsequent patch, we should upstream this test to the shared test repository. You can do that by moving it to a new `credential-management` directory under `third_party/WebKit/LayoutTests/external/wpt/`. jdoerrie 2017/04/24 15:05:45 Done. Show quoted text On 2017/04/24 07:34:08, Mike West wrote: > Either in this patch or a subsequent patch, we should upstream this test to the > shared test repository. You can do that by moving it to a new > `credential-management` directory under > `third_party/WebKit/LayoutTests/external/wpt/`. Done.
19 };	19 };

20	20

21 interface SiteBoundCredential : Credential {	21 interface CredentialUserData {
	Mike West 2017/04/24 07:34:08 Nit: Needs `NoInterfaceObject` + `SecureContext` a Nit: Needs `NoInterfaceObject` + `SecureContext` attributes. jdoerrie 2017/04/24 15:05:45 Done. Show quoted text On 2017/04/24 07:34:08, Mike West wrote: > Nit: Needs `NoInterfaceObject` + `SecureContext` attributes. Done.
22 readonly attribute USVString name;	22 readonly attribute USVString name;

23 readonly attribute USVString iconURL;	23 readonly attribute USVString iconURL;

24 };	24 };

25	25

26 dictionary PasswordCredentialData : SiteBoundCredentialData {	26 dictionary PasswordCredentialData : SiteBoundCredentialData {

27 USVString password;	27 USVString password;

28 };	28 };

29	29

30 typedef (FormData or URLSearchParams) CredentialBodyType;	30 typedef (FormData or URLSearchParams) CredentialBodyType;

31	31

(...skipping 19 matching lines...) Expand all Loading...
51 <script type="text/plain" id="tested">	51 <script type="text/plain" id="tested">

52 interface CredentialsContainer {	52 interface CredentialsContainer {

53 Promise<Credential> get(optional CredentialRequestOptions options);	53 Promise<Credential> get(optional CredentialRequestOptions options);

54 Promise<Credential> store(Credential credential);	54 Promise<Credential> store(Credential credential);

55 Promise<void> requireUserMediation();	55 Promise<void> requireUserMediation();

56 };	56 };

57	57

58 [Constructor(PasswordCredentialData data),	58 [Constructor(PasswordCredentialData data),

59 Constructor(HTMLFormElement form),	59 Constructor(HTMLFormElement form),

60 Exposed=Window]	60 Exposed=Window]

61 interface PasswordCredential : SiteBoundCredential {	61 interface PasswordCredential : Credential {

62 attribute USVString idName;	62 attribute USVString idName;

63 attribute USVString passwordName;	63 attribute USVString passwordName;

64	64

65 attribute CredentialBodyType? additionalData;	65 attribute CredentialBodyType? additionalData;

66 };	66 };

	67 PasswordCredential implements CredentialUserData;

67	68

68 [Constructor(FederatedCredentialData data), Exposed=Window]	69 [Constructor(FederatedCredentialData data), Exposed=Window]

69 interface FederatedCredential : SiteBoundCredential {	70 interface FederatedCredential : Credential {

70 readonly attribute USVString provider;	71 readonly attribute USVString provider;

71 readonly attribute DOMString? protocol;	72 readonly attribute DOMString? protocol;

72 };	73 };

	74 FederatedCredential implements CredentialUserData;

73 </script>	75 </script>

74 <script>	76 <script>

75 "use strict";	77 "use strict";

76 var idl_array = new IdlArray();	78 var idl_array = new IdlArray();

77 idl_array.add_untested_idls(document.querySelector('#untested').textContent) ;	79 idl_array.add_untested_idls(document.querySelector('#untested').textContent) ;

78 idl_array.add_idls(document.querySelector('#tested').textContent);	80 idl_array.add_idls(document.querySelector('#tested').textContent);

79 idl_array.add_objects({	81 idl_array.add_objects({

80 CredentialsContainer: ['navigator.credentials'],	82 CredentialsContainer: ['navigator.credentials'],

81 PasswordCredential: ['new PasswordCredential({ id: "id", password: "pencil ", iconURL: "https://example.com/", name: "name" })'],	83 PasswordCredential: ['new PasswordCredential({ id: "id", password: "pencil ", iconURL: "https://example.com/", name: "name" })'],

82 FederatedCredential: ['new FederatedCredential({ id: "id", provider: "http s://example.com", iconURL: "https://example.com/", name: "name" })']	84 FederatedCredential: ['new FederatedCredential({ id: "id", provider: "http s://example.com", iconURL: "https://example.com/", name: "name" })']

83 });	85 });

84 idl_array.test();	86 idl_array.test();

85 </script>	87 </script>

86	88

OLD	NEW