Reland of Worker: Introduce per-global-scope task scheduler

Reland of Worker: Introduce per-global-scope task scheduler

I couldn't reproduce the failure on my local machine and trybots.
If this still fails the tests only on the specific bot, I'll mark them with
SKIP and fix them in a separate CL. 

Original issue's description:
> Revert of Worker: Introduce per-global-scope task scheduler (patchset #22 id:450001 of https://codereview.chromium.org/2806623004/ )
> 
> Reason for revert:
> Seems to have caused a crash in fast/workers/termination-early.html on Webkit Linux Trusty Leak -
> https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Trusty_Leak/4107/layout-test-results/results.html
> https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/4107
> 
> https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Trusty_Leak/4106/layout-test-results/fast/workers/termination-early-crash-log.txt
> https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/4106
> 
> Original issue's description:
> > Worker: Introduce per-global-scope task scheduler
> > 
> > This CL introduces WorkerGlobalScopeScheduler to make it simpler and saner to
> > manage tasks on worker threads.
> > 
> > Before this CL, tasks on worker threads were always pushed into the thread's
> > default task queue, they should be handled in different ways based on their
> > task types though. For example, worker tasks shouldn't run after the global
> > scope is closed, while thread control tasks should run even after that. To
> > achieve it, worker tasks were always wrapped with WorkerThread's method to check
> > the current thread state. This was so tricky.
> > 
> > After this CL, each global scope has its own task queues like per-frame task
> > scheduler. Worker tasks are pushed into the task queues, control tasks are still
> > pushed into the thread's default task queue though. Thanks to this separation,
> > we can abort only worker tasks by simply unregistering the queues when a global
> > scope is closed.
> > 
> > In addition, this CL unifies postTask interfaces into TaskRunnerHelper (issue
> > 694914), and enables any threads to post a task to worker threads because of
> > thread-safe refcounted WebTaskRunner.
> > 
> > BUG=670534, 694914, 710364
> > 
> > Review-Url: https://codereview.chromium.org/2806623004
> > Cr-Commit-Position: refs/heads/master@{#465841}
> > Committed: https://chromium.googlesource.com/chromium/src/+/d56a35fb25dc388a0506174b9e3fda67337313ce
> 
> TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chromium.org,altimin@chromium.org,nhiroki@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=670534, 694914, 710364
> 
> Review-Url: https://codereview.chromium.org/2831843002
> Cr-Commit-Position: refs/heads/master@{#465892}
> Committed: https://chromium.googlesource.com/chromium/src/+/ee6a4f06b0e0561618669ed56e5997af91108c3e

TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chromium.org,altimin@chromium.org,aboxhall@chromium.org
BUG=670534, 694914, 710364
Review-Url: https://codereview.chromium.org/2832763002
Cr-Commit-Position: refs/heads/master@{#465962}
Committed: https://chromium.googlesource.com/chromium/src/+/7800a474d39eacc36c6c247f6a956e15f5d2489a

[nhiroki, 2017-04-20 04:04:14]

Created Reland of Worker: Introduce per-global-scope task scheduler

[nhiroki, 2017-04-20 04:04:37]

Description was changed from

==========
Reland of Worker: Introduce per-global-scope task scheduler (patchset #1 id:1 of
https://codereview.chromium.org/2831843002/ )

Reason for revert:
Retry

Original issue's description:
> Revert of Worker: Introduce per-global-scope task scheduler (patchset #22
id:450001 of https://codereview.chromium.org/2806623004/ )
> 
> Reason for revert:
> Seems to have caused a crash in fast/workers/termination-early.html on Webkit
Linux Trusty Leak -
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Tru...
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Tru...
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
> Original issue's description:
> > Worker: Introduce per-global-scope task scheduler
> > 
> > This CL introduces WorkerGlobalScopeScheduler to make it simpler and saner
to
> > manage tasks on worker threads.
> > 
> > Before this CL, tasks on worker threads were always pushed into the thread's
> > default task queue, they should be handled in different ways based on their
> > task types though. For example, worker tasks shouldn't run after the global
> > scope is closed, while thread control tasks should run even after that. To
> > achieve it, worker tasks were always wrapped with WorkerThread's method to
check
> > the current thread state. This was so tricky.
> > 
> > After this CL, each global scope has its own task queues like per-frame task
> > scheduler. Worker tasks are pushed into the task queues, control tasks are
still
> > pushed into the thread's default task queue though. Thanks to this
separation,
> > we can abort only worker tasks by simply unregistering the queues when a
global
> > scope is closed.
> > 
> > In addition, this CL unifies postTask interfaces into TaskRunnerHelper
(issue
> > 694914), and enables any threads to post a task to worker threads because of
> > thread-safe refcounted WebTaskRunner.
> > 
> > BUG=670534, 694914, 710364
> > 
> > Review-Url: https://codereview.chromium.org/2806623004
> > Cr-Commit-Position: refs/heads/master@{#465841}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/d56a35fb25dc388a0506174b9e3f...
> 
>
TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chrom...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=670534, 694914, 710364
> 
> Review-Url: https://codereview.chromium.org/2831843002
> Cr-Commit-Position: refs/heads/master@{#465892}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ee6a4f06b0e0561618669ed56e59...

TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=670534, 694914, 710364
==========

to

==========
Reland of Worker: Introduce per-global-scope task scheduler (patchset #1 id:1 of
https://codereview.chromium.org/2831843002/ )

Original issue's description:
> Revert of Worker: Introduce per-global-scope task scheduler (patchset #22
id:450001 of https://codereview.chromium.org/2806623004/ )
> 
> Reason for revert:
> Seems to have caused a crash in fast/workers/termination-early.html on Webkit
Linux Trusty Leak -
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Tru...
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Tru...
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
> Original issue's description:
> > Worker: Introduce per-global-scope task scheduler
> > 
> > This CL introduces WorkerGlobalScopeScheduler to make it simpler and saner
to
> > manage tasks on worker threads.
> > 
> > Before this CL, tasks on worker threads were always pushed into the thread's
> > default task queue, they should be handled in different ways based on their
> > task types though. For example, worker tasks shouldn't run after the global
> > scope is closed, while thread control tasks should run even after that. To
> > achieve it, worker tasks were always wrapped with WorkerThread's method to
check
> > the current thread state. This was so tricky.
> > 
> > After this CL, each global scope has its own task queues like per-frame task
> > scheduler. Worker tasks are pushed into the task queues, control tasks are
still
> > pushed into the thread's default task queue though. Thanks to this
separation,
> > we can abort only worker tasks by simply unregistering the queues when a
global
> > scope is closed.
> > 
> > In addition, this CL unifies postTask interfaces into TaskRunnerHelper
(issue
> > 694914), and enables any threads to post a task to worker threads because of
> > thread-safe refcounted WebTaskRunner.
> > 
> > BUG=670534, 694914, 710364
> > 
> > Review-Url: https://codereview.chromium.org/2806623004
> > Cr-Commit-Position: refs/heads/master@{#465841}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/d56a35fb25dc388a0506174b9e3f...
> 
>
TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chrom...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=670534, 694914, 710364
> 
> Review-Url: https://codereview.chromium.org/2831843002
> Cr-Commit-Position: refs/heads/master@{#465892}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ee6a4f06b0e0561618669ed56e59...

TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=670534, 694914, 710364
==========

[nhiroki, 2017-04-20 04:04:37]

nhiroki@chromium.org changed reviewers:
- aboxhall@chromium.org

[nhiroki, 2017-04-20 04:05:10]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 04:05:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 04:05:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 04:05:36]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2017-04-20 04:10:59]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 04:11:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 04:11:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 04:11:20]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2017-04-20 04:19:31]

Description was changed from

==========
Reland of Worker: Introduce per-global-scope task scheduler (patchset #1 id:1 of
https://codereview.chromium.org/2831843002/ )

Original issue's description:
> Revert of Worker: Introduce per-global-scope task scheduler (patchset #22
id:450001 of https://codereview.chromium.org/2806623004/ )
> 
> Reason for revert:
> Seems to have caused a crash in fast/workers/termination-early.html on Webkit
Linux Trusty Leak -
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Tru...
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Tru...
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
> Original issue's description:
> > Worker: Introduce per-global-scope task scheduler
> > 
> > This CL introduces WorkerGlobalScopeScheduler to make it simpler and saner
to
> > manage tasks on worker threads.
> > 
> > Before this CL, tasks on worker threads were always pushed into the thread's
> > default task queue, they should be handled in different ways based on their
> > task types though. For example, worker tasks shouldn't run after the global
> > scope is closed, while thread control tasks should run even after that. To
> > achieve it, worker tasks were always wrapped with WorkerThread's method to
check
> > the current thread state. This was so tricky.
> > 
> > After this CL, each global scope has its own task queues like per-frame task
> > scheduler. Worker tasks are pushed into the task queues, control tasks are
still
> > pushed into the thread's default task queue though. Thanks to this
separation,
> > we can abort only worker tasks by simply unregistering the queues when a
global
> > scope is closed.
> > 
> > In addition, this CL unifies postTask interfaces into TaskRunnerHelper
(issue
> > 694914), and enables any threads to post a task to worker threads because of
> > thread-safe refcounted WebTaskRunner.
> > 
> > BUG=670534, 694914, 710364
> > 
> > Review-Url: https://codereview.chromium.org/2806623004
> > Cr-Commit-Position: refs/heads/master@{#465841}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/d56a35fb25dc388a0506174b9e3f...
> 
>
TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chrom...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=670534, 694914, 710364
> 
> Review-Url: https://codereview.chromium.org/2831843002
> Cr-Commit-Position: refs/heads/master@{#465892}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ee6a4f06b0e0561618669ed56e59...

TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=670534, 694914, 710364
==========

to

==========
Reland of Worker: Introduce per-global-scope task scheduler (patchset #1 id:1 of
https://codereview.chromium.org/2831843002/ )

Original issue's description:
> Revert of Worker: Introduce per-global-scope task scheduler (patchset #22
id:450001 of https://codereview.chromium.org/2806623004/ )
> 
> Reason for revert:
> Seems to have caused a crash in fast/workers/termination-early.html on Webkit
Linux Trusty Leak -
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Tru...
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Tru...
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
> Original issue's description:
> > Worker: Introduce per-global-scope task scheduler
> > 
> > This CL introduces WorkerGlobalScopeScheduler to make it simpler and saner
to
> > manage tasks on worker threads.
> > 
> > Before this CL, tasks on worker threads were always pushed into the thread's
> > default task queue, they should be handled in different ways based on their
> > task types though. For example, worker tasks shouldn't run after the global
> > scope is closed, while thread control tasks should run even after that. To
> > achieve it, worker tasks were always wrapped with WorkerThread's method to
check
> > the current thread state. This was so tricky.
> > 
> > After this CL, each global scope has its own task queues like per-frame task
> > scheduler. Worker tasks are pushed into the task queues, control tasks are
still
> > pushed into the thread's default task queue though. Thanks to this
separation,
> > we can abort only worker tasks by simply unregistering the queues when a
global
> > scope is closed.
> > 
> > In addition, this CL unifies postTask interfaces into TaskRunnerHelper
(issue
> > 694914), and enables any threads to post a task to worker threads because of
> > thread-safe refcounted WebTaskRunner.
> > 
> > BUG=670534, 694914, 710364
> > 
> > Review-Url: https://codereview.chromium.org/2806623004
> > Cr-Commit-Position: refs/heads/master@{#465841}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/d56a35fb25dc388a0506174b9e3f...
> 
>
TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chrom...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=670534, 694914, 710364
> 
> Review-Url: https://codereview.chromium.org/2831843002
> Cr-Commit-Position: refs/heads/master@{#465892}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ee6a4f06b0e0561618669ed56e59...

TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chrom...
BUG=670534, 694914, 710364
==========

[nhiroki, 2017-04-20 04:19:38]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 04:20:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aboxhall, 2017-04-20 04:21:46]

On 2017/04/20 04:04:14, nhiroki wrote:
> Created Reland of Worker: Introduce per-global-scope task scheduler

Any chance we can hold off on this until we see whether the revert makes the bot
goes green?
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...

[nhiroki, 2017-04-20 04:24:20]

Reviewers: You don't have to review this for now. I'm now investigating why this
caused the crash...

[nhiroki, 2017-04-20 04:27:07]

On 2017/04/20 04:21:46, aboxhall wrote:
> On 2017/04/20 04:04:14, nhiroki wrote:
> > Created Reland of Worker: Introduce per-global-scope task scheduler
> 
> Any chance we can hold off on this until we see whether the revert makes the
bot
> goes green?
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...

Sorry for making you confused. I created this patch just for investigating the
cause. I'll reland this after the bot is recovered and the problem is fixed :)

[nhiroki, 2017-04-20 05:31:21]

The bot returned to green after this patch was reverted. I've tried to reproduce
this on my local machine but couldn't... hmmm

[nhiroki, 2017-04-20 05:41:59]

The CQ bit was unchecked by nhiroki@chromium.org

[nhiroki, 2017-04-20 05:45:37]

On 2017/04/20 05:31:21, nhiroki wrote:
> The bot returned to green after this patch was reverted. I've tried to
reproduce
> this on my local machine but couldn't... hmmm

I scheduled to run this on more trybots (linux_trusty_blink_rel,
linux_trusty_blink_dbg).

[nhiroki, 2017-04-20 08:17:44]

On 2017/04/20 05:45:37, nhiroki wrote:
> On 2017/04/20 05:31:21, nhiroki wrote:
> > The bot returned to green after this patch was reverted. I've tried to
> reproduce
> > this on my local machine but couldn't... hmmm
> 
> I scheduled to run this on more trybots (linux_trusty_blink_rel,
> linux_trusty_blink_dbg).

Hmm... all bots passed the tests. To move forward, let me reland this patch as
is. I'll mark the tests as SKIP and fix it in a separate patch if they still
fail.

[nhiroki, 2017-04-20 08:21:28]

Description was changed from

==========
Reland of Worker: Introduce per-global-scope task scheduler (patchset #1 id:1 of
https://codereview.chromium.org/2831843002/ )

Original issue's description:
> Revert of Worker: Introduce per-global-scope task scheduler (patchset #22
id:450001 of https://codereview.chromium.org/2806623004/ )
> 
> Reason for revert:
> Seems to have caused a crash in fast/workers/termination-early.html on Webkit
Linux Trusty Leak -
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Tru...
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Tru...
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
> Original issue's description:
> > Worker: Introduce per-global-scope task scheduler
> > 
> > This CL introduces WorkerGlobalScopeScheduler to make it simpler and saner
to
> > manage tasks on worker threads.
> > 
> > Before this CL, tasks on worker threads were always pushed into the thread's
> > default task queue, they should be handled in different ways based on their
> > task types though. For example, worker tasks shouldn't run after the global
> > scope is closed, while thread control tasks should run even after that. To
> > achieve it, worker tasks were always wrapped with WorkerThread's method to
check
> > the current thread state. This was so tricky.
> > 
> > After this CL, each global scope has its own task queues like per-frame task
> > scheduler. Worker tasks are pushed into the task queues, control tasks are
still
> > pushed into the thread's default task queue though. Thanks to this
separation,
> > we can abort only worker tasks by simply unregistering the queues when a
global
> > scope is closed.
> > 
> > In addition, this CL unifies postTask interfaces into TaskRunnerHelper
(issue
> > 694914), and enables any threads to post a task to worker threads because of
> > thread-safe refcounted WebTaskRunner.
> > 
> > BUG=670534, 694914, 710364
> > 
> > Review-Url: https://codereview.chromium.org/2806623004
> > Cr-Commit-Position: refs/heads/master@{#465841}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/d56a35fb25dc388a0506174b9e3f...
> 
>
TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chrom...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=670534, 694914, 710364
> 
> Review-Url: https://codereview.chromium.org/2831843002
> Cr-Commit-Position: refs/heads/master@{#465892}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ee6a4f06b0e0561618669ed56e59...

TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chrom...
BUG=670534, 694914, 710364
==========

to

==========
Reland of Worker: Introduce per-global-scope task scheduler

I couldn't reproduce the failure on my local machine and trybots.
If this still fails the tests only on the specific bot, I'll mark them with
SKIP and fix them in a separate CL. 

Original issue's description:
> Revert of Worker: Introduce per-global-scope task scheduler (patchset #22
id:450001 of https://codereview.chromium.org/2806623004/ )
> 
> Reason for revert:
> Seems to have caused a crash in fast/workers/termination-early.html on Webkit
Linux Trusty Leak -
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Tru...
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Tru...
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
> Original issue's description:
> > Worker: Introduce per-global-scope task scheduler
> > 
> > This CL introduces WorkerGlobalScopeScheduler to make it simpler and saner
to
> > manage tasks on worker threads.
> > 
> > Before this CL, tasks on worker threads were always pushed into the thread's
> > default task queue, they should be handled in different ways based on their
> > task types though. For example, worker tasks shouldn't run after the global
> > scope is closed, while thread control tasks should run even after that. To
> > achieve it, worker tasks were always wrapped with WorkerThread's method to
check
> > the current thread state. This was so tricky.
> > 
> > After this CL, each global scope has its own task queues like per-frame task
> > scheduler. Worker tasks are pushed into the task queues, control tasks are
still
> > pushed into the thread's default task queue though. Thanks to this
separation,
> > we can abort only worker tasks by simply unregistering the queues when a
global
> > scope is closed.
> > 
> > In addition, this CL unifies postTask interfaces into TaskRunnerHelper
(issue
> > 694914), and enables any threads to post a task to worker threads because of
> > thread-safe refcounted WebTaskRunner.
> > 
> > BUG=670534, 694914, 710364
> > 
> > Review-Url: https://codereview.chromium.org/2806623004
> > Cr-Commit-Position: refs/heads/master@{#465841}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/d56a35fb25dc388a0506174b9e3f...
> 
>
TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chrom...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=670534, 694914, 710364
> 
> Review-Url: https://codereview.chromium.org/2831843002
> Cr-Commit-Position: refs/heads/master@{#465892}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ee6a4f06b0e0561618669ed56e59...

TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chrom...
BUG=670534, 694914, 710364
==========

[nhiroki, 2017-04-20 08:22:21]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2017-04-20 08:23:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2017-04-20 10:03:23]

lgtm to reland.

[commit-bot: I haz the power, 2017-04-20 10:06:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492676541293460, "parent_rev":
"a4f64617512a9ec847024e4602ca060e3cac4813", "commit_rev":
"7800a474d39eacc36c6c247f6a956e15f5d2489a"}

[commit-bot: I haz the power, 2017-04-20 10:07:04]

Description was changed from

==========
Reland of Worker: Introduce per-global-scope task scheduler

I couldn't reproduce the failure on my local machine and trybots.
If this still fails the tests only on the specific bot, I'll mark them with
SKIP and fix them in a separate CL. 

Original issue's description:
> Revert of Worker: Introduce per-global-scope task scheduler (patchset #22
id:450001 of https://codereview.chromium.org/2806623004/ )
> 
> Reason for revert:
> Seems to have caused a crash in fast/workers/termination-early.html on Webkit
Linux Trusty Leak -
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Tru...
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Tru...
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
> Original issue's description:
> > Worker: Introduce per-global-scope task scheduler
> > 
> > This CL introduces WorkerGlobalScopeScheduler to make it simpler and saner
to
> > manage tasks on worker threads.
> > 
> > Before this CL, tasks on worker threads were always pushed into the thread's
> > default task queue, they should be handled in different ways based on their
> > task types though. For example, worker tasks shouldn't run after the global
> > scope is closed, while thread control tasks should run even after that. To
> > achieve it, worker tasks were always wrapped with WorkerThread's method to
check
> > the current thread state. This was so tricky.
> > 
> > After this CL, each global scope has its own task queues like per-frame task
> > scheduler. Worker tasks are pushed into the task queues, control tasks are
still
> > pushed into the thread's default task queue though. Thanks to this
separation,
> > we can abort only worker tasks by simply unregistering the queues when a
global
> > scope is closed.
> > 
> > In addition, this CL unifies postTask interfaces into TaskRunnerHelper
(issue
> > 694914), and enables any threads to post a task to worker threads because of
> > thread-safe refcounted WebTaskRunner.
> > 
> > BUG=670534, 694914, 710364
> > 
> > Review-Url: https://codereview.chromium.org/2806623004
> > Cr-Commit-Position: refs/heads/master@{#465841}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/d56a35fb25dc388a0506174b9e3f...
> 
>
TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chrom...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=670534, 694914, 710364
> 
> Review-Url: https://codereview.chromium.org/2831843002
> Cr-Commit-Position: refs/heads/master@{#465892}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ee6a4f06b0e0561618669ed56e59...

TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chrom...
BUG=670534, 694914, 710364
==========

to

==========
Reland of Worker: Introduce per-global-scope task scheduler

I couldn't reproduce the failure on my local machine and trybots.
If this still fails the tests only on the specific bot, I'll mark them with
SKIP and fix them in a separate CL. 

Original issue's description:
> Revert of Worker: Introduce per-global-scope task scheduler (patchset #22
id:450001 of https://codereview.chromium.org/2806623004/ )
> 
> Reason for revert:
> Seems to have caused a crash in fast/workers/termination-early.html on Webkit
Linux Trusty Leak -
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Tru...
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Tru...
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linu...
> 
> Original issue's description:
> > Worker: Introduce per-global-scope task scheduler
> > 
> > This CL introduces WorkerGlobalScopeScheduler to make it simpler and saner
to
> > manage tasks on worker threads.
> > 
> > Before this CL, tasks on worker threads were always pushed into the thread's
> > default task queue, they should be handled in different ways based on their
> > task types though. For example, worker tasks shouldn't run after the global
> > scope is closed, while thread control tasks should run even after that. To
> > achieve it, worker tasks were always wrapped with WorkerThread's method to
check
> > the current thread state. This was so tricky.
> > 
> > After this CL, each global scope has its own task queues like per-frame task
> > scheduler. Worker tasks are pushed into the task queues, control tasks are
still
> > pushed into the thread's default task queue though. Thanks to this
separation,
> > we can abort only worker tasks by simply unregistering the queues when a
global
> > scope is closed.
> > 
> > In addition, this CL unifies postTask interfaces into TaskRunnerHelper
(issue
> > 694914), and enables any threads to post a task to worker threads because of
> > thread-safe refcounted WebTaskRunner.
> > 
> > BUG=670534, 694914, 710364
> > 
> > Review-Url: https://codereview.chromium.org/2806623004
> > Cr-Commit-Position: refs/heads/master@{#465841}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/d56a35fb25dc388a0506174b9e3f...
> 
>
TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chrom...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=670534, 694914, 710364
> 
> Review-Url: https://codereview.chromium.org/2831843002
> Cr-Commit-Position: refs/heads/master@{#465892}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ee6a4f06b0e0561618669ed56e59...

TBR=kinuko@chromium.org,haraken@chromium.org,tzik@chromium.org,skyostil@chrom...
BUG=670534, 694914, 710364

Review-Url: https://codereview.chromium.org/2832763002
Cr-Commit-Position: refs/heads/master@{#465962}
Committed:
https://chromium.googlesource.com/chromium/src/+/7800a474d39eacc36c6c247f6a95...
==========

[commit-bot: I haz the power, 2017-04-20 10:07:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7800a474d39eacc36c6c247f6a95...