Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 2832753002: memory_coordinator: Use TimeTicks to suppress memory condition update (Closed)

Created:
3 years, 8 months ago by bashi
Modified:
3 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, jam, chrome-grc-reviews+memory_chromium.org, darin-cc_chromium.org, fmeawad
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

memory_coordinator: Use TimeTicks to suppress memory condition update Before this CL ForceSetMemoryCondition() was implemented by rescheduling the task which updates memory condition. It resulted in not calling UpdateConditionIfNeeded() until a given interval is passed. This is no longer an expected behavior because UpdateConditionIfNeeded() does more work than just updating condition. Instead of rescheduing the task, add a TimeTicks to suppress memory condition update for a given interval. BUG=696844 Review-Url: https://codereview.chromium.org/2832753002 Cr-Commit-Position: refs/heads/master@{#465951} Committed: https://chromium.googlesource.com/chromium/src/+/e475d97ed39fecfb67814dcf0607746f8aea1cb4

Patch Set 1 #

Patch Set 2 : Remove unused const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M content/browser/memory/memory_coordinator_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/memory/memory_monitor_android.cc View 1 2 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
bashi
PTAL. Existing unittests should cover the change.
3 years, 8 months ago (2017-04-20 05:02:07 UTC) #8
haraken
LGTM
3 years, 8 months ago (2017-04-20 07:39:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832753002/20001
3 years, 8 months ago (2017-04-20 08:32:55 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 08:36:51 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e475d97ed39fecfb67814dcf0607...

Powered by Google App Engine
This is Rietveld 408576698