Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2832743002: Add ScrollTree::FindNodeFromElementId (Closed)

Created:
3 years, 8 months ago by pdr.
Modified:
3 years, 8 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ScrollTree::FindNodeFromElementId The transform tree and effect trees both have this function and the scroll tree feels left out. This patch adds FindNodeFromElementId to the scroll tree and uses it in LayerTreeImpl::PushPropertiesTo. A future patch will add more callers. BUG=693740 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2832743002 Cr-Commit-Position: refs/heads/master@{#466087} Committed: https://chromium.googlesource.com/chromium/src/+/7868a2fd251dc273fedd774f50a3b06fb8d81f9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M cc/trees/layer_tree_impl.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M cc/trees/property_tree.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/property_tree.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
pdr.
3 years, 8 months ago (2017-04-20 16:16:17 UTC) #8
enne (OOO)
lgtm
3 years, 8 months ago (2017-04-20 18:42:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832743002/1
3 years, 8 months ago (2017-04-20 18:43:10 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 19:04:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7868a2fd251dc273fedd774f50a3...

Powered by Google App Engine
This is Rietveld 408576698