Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2832693002: MD Settings: search mode shouldn't have overscrolls (Closed)

Created:
3 years, 8 months ago by scottchen
Modified:
3 years, 8 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: search mode shouldn't have overscrolls BUG=689390 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2832693002 Cr-Commit-Position: refs/heads/master@{#466054} Committed: https://chromium.googlesource.com/chromium/src/+/7253ca232d77ec26c62c72bff4d9125e37bb8c58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/resources/settings/settings_main/settings_main.js View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
scottchen
3 years, 8 months ago (2017-04-20 00:24:21 UTC) #4
dpapad
lgtm
3 years, 8 months ago (2017-04-20 00:43:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832693002/1
3 years, 8 months ago (2017-04-20 17:36:42 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 17:45:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7253ca232d77ec26c62c72bff4d9...

Powered by Google App Engine
This is Rietveld 408576698