[Merge to M59] Break circular dependency between InitializeDeviceDisablingManager and DeviceDisable…

[Merge to M59] Break circular dependency between InitializeDeviceDisablingManager and DeviceDisabledScreen

crrev.com/2714493002 uncovered a circular dependency between BrowserProcessPlatformPart::InitializeDeviceDisablingManager and DeviceDisabledScreen::DeviceDisabledScreen. Previously there was a part in the call stack that forked off into an asynchronous call, DeviceDisablingManager::UpdateFromCrosSettings, which would queue up a callback in case the CrosSettings wasn't ready yet (and it wasn't). The referenced CL fixed a bug by immediately loading the settings, but it unfortunately broke the assumption here.

The suggested fix breaks the dependency by moving Init() outside of the constructor (so the object exists at the time further code called from Init() tries to access it).

This bug was causing a crash for disabled devices (ui wouldn't start).

The circle starts on the "device_disabling_manager_.reset" line.

TEST=manual
BUG=709518
Review-Url: https://codereview.chromium.org/2815893002
Cr-Commit-Position: refs/heads/master@{#464708}
(cherry picked from commit 87c761f625a57653cc241f5691cb013ad9ca3efa)

Review-Url: https://codereview.chromium.org/2832673002 .
Cr-Commit-Position: refs/branch-heads/3071@{#68}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/c438eb0c1cf953e341a196d7ce57e28eecec7aa7

[Ivan Šandrk, 2017-04-19 22:13:13]

Description was changed from

==========
[Merge to M59] Break circular dependency between
InitializeDeviceDisablingManager and DeviceDisabledScreen

crrev.com/2714493002 uncovered a circular dependency between
BrowserProcessPlatformPart::InitializeDeviceDisablingManager and
DeviceDisabledScreen::DeviceDisabledScreen. Previously there was a part in the
call stack that forked off into an asynchronous call,
DeviceDisablingManager::UpdateFromCrosSettings, which would queue up a callback
in case the CrosSettings wasn't ready yet (and it wasn't). The referenced CL
fixed a bug by immediately loading the settings, but it unfortunately broke the
assumption here.

The suggested fix breaks the dependency by moving Init() outside of the
constructor (so the object exists at the time further code called from Init()
tries to access it).

This bug was causing a crash for disabled devices (ui wouldn't start).

The circle starts on the "device_disabling_manager_.reset" line.

TEST=manual
BUG=709518

Review-Url: https://codereview.chromium.org/2815893002
Cr-Commit-Position: refs/heads/master@{#464708}
(cherry picked from commit 87c761f625a57653cc241f5691cb013ad9ca3efa)
==========

to

==========
[Merge to M59] Break circular dependency between
InitializeDeviceDisablingManager and DeviceDisabledScreen

crrev.com/2714493002 uncovered a circular dependency between
BrowserProcessPlatformPart::InitializeDeviceDisablingManager and
DeviceDisabledScreen::DeviceDisabledScreen. Previously there was a part in the
call stack that forked off into an asynchronous call,
DeviceDisablingManager::UpdateFromCrosSettings, which would queue up a callback
in case the CrosSettings wasn't ready yet (and it wasn't). The referenced CL
fixed a bug by immediately loading the settings, but it unfortunately broke the
assumption here.

The suggested fix breaks the dependency by moving Init() outside of the
constructor (so the object exists at the time further code called from Init()
tries to access it).

This bug was causing a crash for disabled devices (ui wouldn't start).

The circle starts on the "device_disabling_manager_.reset" line.

TEST=manual
BUG=709518

Review-Url: https://codereview.chromium.org/2815893002
Cr-Commit-Position: refs/heads/master@{#464708}
(cherry picked from commit 87c761f625a57653cc241f5691cb013ad9ca3efa)

Review-Url: https://codereview.chromium.org/2832673002 .
Cr-Commit-Position: refs/branch-heads/3071@{#68}
Cr-Branched-From:
a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed:
https://chromium.googlesource.com/chromium/src/+/c438eb0c1cf953e341a196d7ce57...
==========

[Ivan Šandrk, 2017-04-19 22:13:15]

Committed patchset #1 (id:1) manually as
c438eb0c1cf953e341a196d7ce57e28eecec7aa7.