Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(54)

Issue 2832643004: Fix potential missing nul character on resolved symbol names (Closed)

Created:
2 years, 2 months ago by etienneb
Modified:
2 years, 2 months ago
Reviewers:
erikchen, Will Harris
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME), awong, chrisha
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix potential missing nul character on resolved symbol names The symbol name returned by SymFromName may not contains a NUL character when the symbol name is exactly the size of the buffer. It believe this may also happen when the symbol name is too long and truncated. The original code is based on: https://msdn.microsoft.com/en-us/library/windows/desktop/ms680580(v=vs.85).aspx A right implementation can be found here: https://cs.chromium.org/chromium/src/base/debug/stack_trace_win.cc?l=145&rcl=f4ecb9e37e9e2d59e32b8b96f23ac4a1e33b9552 As described here: https://msdn.microsoft.com/en-us/library/windows/desktop/ms680686(v=vs.85).aspx NameLen The length of the name, in characters, not including the null-terminating character. MaxNameLen The size of the Name buffer, in characters. If this member is 0, the Name member is not used. This issue was causing the catapult symbolisation script to encode incorrect (random) characters into the symbol names. See the example in the bug. R=wfh@chromium.org, chrisha@chromium.org, erikchen@chromium.org, ajwong@chromium.org BUG=713741 Review-Url: https://codereview.chromium.org/2832643004 Cr-Commit-Position: refs/heads/master@{#466098} Committed: https://chromium.googlesource.com/chromium/src/+/0ff178d157b08717ac405502ad648e6f7bfecd1d

Patch Set 1 #

Patch Set 2 : fix missing local change description #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M third_party/tcmalloc/README.chromium View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/tcmalloc/chromium/src/windows/addr2line-pdb.c View 5 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
etienneb
PTAL
2 years, 2 months ago (2017-04-20 18:01:11 UTC) #1
Will Harris
who would you like to review this, you have listed four people...? normally, third_party/tcmalloc/README.chromium is ...
2 years, 2 months ago (2017-04-20 18:03:35 UTC) #2
erikchen
On 2017/04/20 18:03:35, Will Harris wrote: > who would you like to review this, you ...
2 years, 2 months ago (2017-04-20 18:07:12 UTC) #3
etienneb
2 years, 2 months ago (2017-04-20 18:22:45 UTC) #5
etienneb
whf, done. PTAnL
2 years, 2 months ago (2017-04-20 19:15:08 UTC) #7
Will Harris
lgtm thanks for the great fix!
2 years, 2 months ago (2017-04-20 19:32:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832643004/40001
2 years, 2 months ago (2017-04-20 19:43:15 UTC) #11
commit-bot: I haz the power
2 years, 2 months ago (2017-04-20 19:58:19 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0ff178d157b08717ac405502ad64...

Powered by Google App Engine
This is Rietveld 408576698