Fix potential missing nul character on resolved symbol names

Fix potential missing nul character on resolved symbol names

The symbol name returned by SymFromName may not contains a NUL character
when the symbol name is exactly the size of the buffer. It believe this
may also happen when the symbol name is too long and truncated.

The original code is based on:
  https://msdn.microsoft.com/en-us/library/windows/desktop/ms680580(v=vs.85).aspx

A right implementation can be found here:
  https://cs.chromium.org/chromium/src/base/debug/stack_trace_win.cc?l=145&rcl=f4ecb9e37e9e2d59e32b8b96f23ac4a1e33b9552


As described here:
  https://msdn.microsoft.com/en-us/library/windows/desktop/ms680686(v=vs.85).aspx

  NameLen
    The length of the name, in characters, not including the null-terminating character.
  MaxNameLen
    The size of the Name buffer, in characters. If this member is 0, the Name member is not used.

This issue was causing the catapult symbolisation script to encode incorrect (random) characters into the symbol names.
See the example in the bug.

R=wfh@chromium.org, chrisha@chromium.org, erikchen@chromium.org, ajwong@chromium.org
BUG=713741
Review-Url: https://codereview.chromium.org/2832643004
Cr-Commit-Position: refs/heads/master@{#466098}
Committed: https://chromium.googlesource.com/chromium/src/+/0ff178d157b08717ac405502ad648e6f7bfecd1d

[etienneb, 2017-04-20 18:01:11]

PTAL

[Will Harris, 2017-04-20 18:03:35]

who would you like to review this, you have listed four people...?

normally, third_party/tcmalloc/README.chromium is updated with local patches.

[erikchen, 2017-04-20 18:07:12]

On 2017/04/20 18:03:35, Will Harris wrote:
> who would you like to review this, you have listed four people...?
> 
> normally, third_party/tcmalloc/README.chromium is updated with local patches.

Very nice find. lgtm once you address wfh's suggestion.

[etienneb, 2017-04-20 18:22:45]

etienneb@chromium.org changed reviewers:
- ajwong@chromium.org, chrisha@chromium.org

[etienneb, 2017-04-20 18:31:03]

Description was changed from

==========
Fix potential missing nul character on resolved symbol names

The symbol name returned by SymFromName may not contains a NUL character
when the symbol name is exactly the size of the buffer. It believe this
may also happen when the symbol name is too long and truncated.

The original code is based on:
 
https://msdn.microsoft.com/en-us/library/windows/desktop/ms680580(v=vs.85).aspx

A right implementation can be found here:
 
https://cs.corp.google.com/steel/external/chromium/base/debug/stack_trace_win...


As described here:
 
https://msdn.microsoft.com/en-us/library/windows/desktop/ms680686(v=vs.85).aspx

  NameLen
    The length of the name, in characters, not including the null-terminating
character.
  MaxNameLen
    The size of the Name buffer, in characters. If this member is 0, the Name
member is not used.

This issue was causing the catapult symbolisation script to encode incorrect
(random) characters into the symbol names.
See the example in the bug.

R=wfh@chromium.org, chrisha@chromium.org, erikchen@chromium.org,
ajwong@chromium.org
BUG=713741
==========

to

==========
Fix potential missing nul character on resolved symbol names

The symbol name returned by SymFromName may not contains a NUL character
when the symbol name is exactly the size of the buffer. It believe this
may also happen when the symbol name is too long and truncated.

The original code is based on:
 
https://msdn.microsoft.com/en-us/library/windows/desktop/ms680580(v=vs.85).aspx

A right implementation can be found here:
 
https://cs.chromium.org/chromium/src/base/debug/stack_trace_win.cc?l=145&rcl=...


As described here:
 
https://msdn.microsoft.com/en-us/library/windows/desktop/ms680686(v=vs.85).aspx

  NameLen
    The length of the name, in characters, not including the null-terminating
character.
  MaxNameLen
    The size of the Name buffer, in characters. If this member is 0, the Name
member is not used.

This issue was causing the catapult symbolisation script to encode incorrect
(random) characters into the symbol names.
See the example in the bug.

R=wfh@chromium.org, chrisha@chromium.org, erikchen@chromium.org,
ajwong@chromium.org
BUG=713741
==========

[etienneb, 2017-04-20 19:15:08]

whf, done.
PTAnL

[Will Harris, 2017-04-20 19:32:24]

lgtm thanks for the great fix!

[etienneb, 2017-04-20 19:42:06]

The CQ bit was checked by etienneb@chromium.org

[etienneb, 2017-04-20 19:42:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/2832643004/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2017-04-20 19:43:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 19:58:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492717326097670,
"parent_rev": "79743d6711cd3e10938f7a7fb057dd065dca3822", "commit_rev":
"0ff178d157b08717ac405502ad648e6f7bfecd1d"}

[commit-bot: I haz the power, 2017-04-20 19:58:18]

Description was changed from

==========
Fix potential missing nul character on resolved symbol names

The symbol name returned by SymFromName may not contains a NUL character
when the symbol name is exactly the size of the buffer. It believe this
may also happen when the symbol name is too long and truncated.

The original code is based on:
 
https://msdn.microsoft.com/en-us/library/windows/desktop/ms680580(v=vs.85).aspx

A right implementation can be found here:
 
https://cs.chromium.org/chromium/src/base/debug/stack_trace_win.cc?l=145&rcl=...


As described here:
 
https://msdn.microsoft.com/en-us/library/windows/desktop/ms680686(v=vs.85).aspx

  NameLen
    The length of the name, in characters, not including the null-terminating
character.
  MaxNameLen
    The size of the Name buffer, in characters. If this member is 0, the Name
member is not used.

This issue was causing the catapult symbolisation script to encode incorrect
(random) characters into the symbol names.
See the example in the bug.

R=wfh@chromium.org, chrisha@chromium.org, erikchen@chromium.org,
ajwong@chromium.org
BUG=713741
==========

to

==========
Fix potential missing nul character on resolved symbol names

The symbol name returned by SymFromName may not contains a NUL character
when the symbol name is exactly the size of the buffer. It believe this
may also happen when the symbol name is too long and truncated.

The original code is based on:
 
https://msdn.microsoft.com/en-us/library/windows/desktop/ms680580(v=vs.85).aspx

A right implementation can be found here:
 
https://cs.chromium.org/chromium/src/base/debug/stack_trace_win.cc?l=145&rcl=...


As described here:
 
https://msdn.microsoft.com/en-us/library/windows/desktop/ms680686(v=vs.85).aspx

  NameLen
    The length of the name, in characters, not including the null-terminating
character.
  MaxNameLen
    The size of the Name buffer, in characters. If this member is 0, the Name
member is not used.

This issue was causing the catapult symbolisation script to encode incorrect
(random) characters into the symbol names.
See the example in the bug.

R=wfh@chromium.org, chrisha@chromium.org, erikchen@chromium.org,
ajwong@chromium.org
BUG=713741

Review-Url: https://codereview.chromium.org/2832643004
Cr-Commit-Position: refs/heads/master@{#466098}
Committed:
https://chromium.googlesource.com/chromium/src/+/0ff178d157b08717ac405502ad64...
==========

[commit-bot: I haz the power, 2017-04-20 19:58:19]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0ff178d157b08717ac405502ad64...