Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2832603002: Only store previous clip rects for PaintLayers that support subsequences. (Closed)

Created:
3 years, 8 months ago by chrishtr
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Only store previous clip rects for PaintLayers that support subsequences. To do this: 2. When updating paint properties, only invalidate painting optimizations like subsequence for PaintLayers that support it (stacking context, SVG root), or have clip-related properties BUG=692614, 711413 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2810503002 Cr-Commit-Position: refs/heads/master@{#464670} (cherry picked from commit d1cf31c84ed81fce3a5033e601afafd402fee87f) Review-Url: https://codereview.chromium.org/2832603002 . Cr-Commit-Position: refs/branch-heads/3071@{#57} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/a3ba22889b3f2565f6e430eca4a827e0e52e0301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -43 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayer.h View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 3 chunks +4 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerTest.cpp View 1 chunk +43 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp View 7 chunks +26 lines, -29 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
chrishtr
3 years, 8 months ago (2017-04-19 18:15:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a3ba22889b3f2565f6e430eca4a827e0e52e0301.

Powered by Google App Engine
This is Rietveld 408576698