Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2832533002: [ObjC ARC] Converts ios/public/provider/chrome/browser/omaha:omaha to ARC. (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/public/provider/chrome/browser/omaha:omaha to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2832533002 Cr-Commit-Position: refs/heads/master@{#465924} Committed: https://chromium.googlesource.com/chromium/src/+/2b68896e78ef68ba075d12a87a1683da7e28d111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/public/provider/chrome/browser/omaha/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/omaha/omaha_service_provider.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-19 16:09:57 UTC) #4
sdefresne
lgtm
3 years, 8 months ago (2017-04-19 16:34:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832533002/1
3 years, 8 months ago (2017-04-20 06:44:14 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 06:49:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b68896e78ef68ba075d12a87a16...

Powered by Google App Engine
This is Rietveld 408576698