Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2832503002: Fix double session-restore bug. (Closed)

Created:
3 years, 8 months ago by chrisha
Modified:
3 years, 8 months ago
Reviewers:
tmartino, sky
CC:
brucedawson, chromium-reviews, rpop, shrike
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix double session-restore bug. Currently on a post-crash startup with the --restore-last-session flag specified an automatic session restore occurs, and an infobar offering an additional session restore is created. Clicking "restore" on the infobar results in the session being restored twice. This CL removes the logic that makes the flag automatically restore the session post-crash. This diminishes the power of the flag somewhat, but allows it to continue working in support of OS-specific "continue where you left of" functionality on Windows and OS X. BUG=707998 Review-Url: https://codereview.chromium.org/2832503002 Cr-Commit-Position: refs/heads/master@{#465665} Committed: https://chromium.googlesource.com/chromium/src/+/92f8ca3fa43fbe22f303afc4c464924dccd1ccbe

Patch Set 1 #

Patch Set 2 : Fix unittest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M chrome/browser/ui/startup/startup_browser_creator_impl.h View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
chrisha
PTAL?
3 years, 8 months ago (2017-04-19 15:12:15 UTC) #2
tmartino
lgtm
3 years, 8 months ago (2017-04-19 16:05:47 UTC) #10
sky
LGTM
3 years, 8 months ago (2017-04-19 17:34:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832503002/20001
3 years, 8 months ago (2017-04-19 17:48:35 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 17:55:09 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/92f8ca3fa43fbe22f303afc4c464...

Powered by Google App Engine
This is Rietveld 408576698