Convert constructor/stereopanner.html to use new Audit

Convert constructor/stereopanner.html to use new Audit

Manually converted to use new Audit.

BUG=704967
TEST=constructor/stereopanner.html

Review-Url: https://codereview.chromium.org/2832493005
Cr-Commit-Position: refs/heads/master@{#469011}
Committed: https://chromium.googlesource.com/chromium/src/+/e1456e345d0cbaf0443db394f98b744ad13f15c0

[Raymond Toy, 2017-04-26 14:58:26]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-04-26 14:58:27]

PTAL

[hongchan, 2017-04-28 18:40:52]

https://codereview.chromium.org/2832493005/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html
(right):

https://codereview.chromium.org/2832493005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html:50: var
options = {channelCount: 1};
I think this can be refactored. WDYT?

[Raymond Toy, 2017-04-28 19:55:14]

https://codereview.chromium.org/2832493005/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html
(right):

https://codereview.chromium.org/2832493005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html:50: var
options = {channelCount: 1};
On 2017/04/28 18:40:52, hongchan wrote:
> I think this can be refactored. WDYT?

Refactored how?

[Raymond Toy, 2017-04-28 19:55:38]

On 2017/04/28 at 18:40:52, hongchan wrote:
>
https://codereview.chromium.org/2832493005/diff/40001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html
(right):
> 
>
https://codereview.chromium.org/2832493005/diff/40001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html:50: var
options = {channelCount: 1};
> I think this can be refactored. WDYT?

Refactored how?

[hongchan, 2017-05-02 16:35:22]

https://codereview.chromium.org/2832493005/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html
(right):

https://codereview.chromium.org/2832493005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html:50: var
options = {channelCount: 1};
On 2017/04/28 19:55:14, Raymond Toy wrote:
> On 2017/04/28 18:40:52, hongchan wrote:
> > I think this can be refactored. WDYT?
> 
> Refactored how?

Something like this?

function checkStereoPannerNodeConstruction(options, should) { ... }

[Raymond Toy, 2017-05-02 18:19:00]

On 2017/05/02 16:35:22, hongchan wrote:
>
https://codereview.chromium.org/2832493005/diff/40001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html
> (right):
> 
>
https://codereview.chromium.org/2832493005/diff/40001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/webaudio/constructor/stereopanner.html:50: var
> options = {channelCount: 1};
> On 2017/04/28 19:55:14, Raymond Toy wrote:
> > On 2017/04/28 18:40:52, hongchan wrote:
> > > I think this can be refactored. WDYT?
> > 
> > Refactored how?
> 
> Something like this?
> 
> function checkStereoPannerNodeConstruction(options, should) { ... }

As discussed offline, I understand what is to be refactored, but not in this CL.
I'll file a bug on this.

[hongchan, 2017-05-03 15:48:25]

ACK on the refactoring with a separate CL.

lgtm

[Raymond Toy, 2017-05-03 15:58:10]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-05-03 15:58:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 17:11:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493827090828200,
"parent_rev": "1fcc6d6a6ac58eabe2c77a804e3220318a0dc1f3", "commit_rev":
"e1456e345d0cbaf0443db394f98b744ad13f15c0"}

[commit-bot: I haz the power, 2017-05-03 17:11:39]

Description was changed from

==========
Convert constructor/stereopanner.html to use new Audit

Manually converted to use new Audit.

BUG=704967
TEST=constructor/stereopanner.html
==========

to

==========
Convert constructor/stereopanner.html to use new Audit

Manually converted to use new Audit.

BUG=704967
TEST=constructor/stereopanner.html

Review-Url: https://codereview.chromium.org/2832493005
Cr-Commit-Position: refs/heads/master@{#469011}
Committed:
https://chromium.googlesource.com/chromium/src/+/e1456e345d0cbaf0443db394f98b...
==========

[commit-bot: I haz the power, 2017-05-03 17:11:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e1456e345d0cbaf0443db394f98b...