Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2832423003: Fix Swarming UI timezone bug (Closed)

Created:
3 years, 8 months ago by kjlubick
Modified:
3 years, 8 months ago
Reviewers:
KevinL, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Fix Swarming UI timezone bug Also consolidate time parsing logic. BUG=714599 Review-Url: https://codereview.chromium.org/2832423003 Committed: https://github.com/luci/luci-py/commit/b929dd8854b52b2abb08b6d4b5710dfca998aa1e

Patch Set 1 #

Patch Set 2 : Fix copy-pasta and use sk.human #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -50 lines) Patch
M appengine/swarming/ui/build/elements.html View 1 4 chunks +4 lines, -4 lines 0 comments Download
M appengine/swarming/ui/build/js/js.js View 1 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list-data.html View 2 chunks +5 lines, -9 lines 0 comments Download
M appengine/swarming/ui/res/imp/botpage/bot-page-data.html View 4 chunks +3 lines, -24 lines 0 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-list-data.html View 1 1 chunk +1 line, -4 lines 0 comments Download
M appengine/swarming/ui/res/imp/taskpage/task-page-data.html View 2 chunks +2 lines, -8 lines 0 comments Download
M appengine/swarming/ui/res/js/common.js View 1 1 chunk +23 lines, -0 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
kjlubick
3 years, 8 months ago (2017-04-24 13:14:01 UTC) #2
kjlubick
See it live on https://2766-9c9155b-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/botlist?c=id&c=os&c=task&c=status&c=last_seen&l=100&q=last&s=id%3Aasc
3 years, 8 months ago (2017-04-24 13:14:38 UTC) #3
stephana
On 2017/04/24 13:14:38, kjlubick wrote: > See it live on > > https://2766-9c9155b-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/botlist?c=id&c=os&c=task&c=status&c=last_seen&l=100&q=last&s=id%3Aasc lgtm w/ ...
3 years, 8 months ago (2017-04-24 13:27:05 UTC) #4
stephana
https://codereview.chromium.org/2832423003/diff/20001/appengine/swarming/ui/res/js/common.js File appengine/swarming/ui/res/js/common.js (right): https://codereview.chromium.org/2832423003/diff/20001/appengine/swarming/ui/res/js/common.js#newcode89 appengine/swarming/ui/res/js/common.js:89: // epoch? That would be more consistent. +1 for ...
3 years, 8 months ago (2017-04-24 13:27:14 UTC) #5
KevinL
lgtm
3 years, 8 months ago (2017-04-24 13:30:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832423003/20001
3 years, 8 months ago (2017-04-24 13:30:23 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 13:33:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/b929dd8854b52b2abb08b6d4b5710dfca998aa1e

Powered by Google App Engine
This is Rietveld 408576698