Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 2832383002: Add --passthrough command line arg for Telemetry-based GPU tests. (Closed)

Created:
3 years, 8 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke, nednguyen
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Zhenyao Mo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add --passthrough command line arg for Telemetry-based GPU tests. This will re-enable display of warnings that a test was expected to fail, but passed. BUG=710065 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2832383002 Cr-Commit-Position: refs/heads/master@{#466835} Committed: https://chromium.googlesource.com/chromium/src/+/5d00435578e14a407425e7bd19c7be8727254fe8

Patch Set 1 #

Patch Set 2 : Preemptive rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+574 lines, -1 line) Patch
M content/test/gpu/generate_buildbot_json.py View 1 chunk +5 lines, -1 line 0 comments Download
M testing/buildbot/chromium.gpu.json View 80 chunks +80 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 450 chunks +450 lines, -0 lines 0 comments Download
M testing/buildbot/client.v8.fyi.json View 39 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Ken Russell (switch to Gerrit)
PTAL. Tested locally on macOS and verified that --passthrough displays what's desired. (Not 100% sure ...
3 years, 8 months ago (2017-04-23 01:31:48 UTC) #5
nednguyen
lgtm
3 years, 8 months ago (2017-04-23 16:50:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832383002/20001
3 years, 8 months ago (2017-04-24 23:10:28 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5d00435578e14a407425e7bd19c7be8727254fe8
3 years, 8 months ago (2017-04-25 00:27:55 UTC) #14
Dirk Pranke
Can you post some examples of the difference between --verbose and --passthrough? I wouldn't have ...
3 years, 8 months ago (2017-04-25 00:36:33 UTC) #15
Ken Russell (switch to Gerrit)
On 2017/04/25 00:36:33, Dirk Pranke wrote: > Can you post some examples of the difference ...
3 years, 8 months ago (2017-04-25 01:23:12 UTC) #16
Dirk Pranke
3 years, 8 months ago (2017-04-25 01:36:07 UTC) #17
Message was sent while issue was closed.
On 2017/04/25 01:23:12, Ken Russell wrote:
> On 2017/04/25 00:36:33, Dirk Pranke wrote:
> > Can you post some examples of the difference between --verbose and
> > --passthrough? I wouldn't have thought passthrough would normally have an
> effect
> > for this sort of thing, it's mostly intended for interactive debugging.
> 
> They're attached to
> https://bugs.chromium.org/p/chromium/issues/detail?id=710065#c15 .
> 
> -vv in particular was much too verbose. --passthrough allowed pretty much
> exactly the desired logging through, though due to timestamps and PIDs showing
> up in the logs I didn't get to the bottom of all of the differences when
adding
> it.

Ah, okay, --passthrough is giving you the stdout output for passed tests that
would otherwise be swallowed. Makes sense, I think.

Powered by Google App Engine
This is Rietveld 408576698