Add --passthrough command line arg for Telemetry-based GPU tests.

Add --passthrough command line arg for Telemetry-based GPU tests.

This will re-enable display of warnings that a test was expected to
fail, but passed.

BUG=710065
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2832383002
Cr-Commit-Position: refs/heads/master@{#466835}
Committed: https://chromium.googlesource.com/chromium/src/+/5d00435578e14a407425e7bd19c7be8727254fe8

[Ken Russell (switch to Gerrit), 2017-04-23 01:29:07]

Description was changed from

==========
Add --passthrough command line arg for Telemetry-based GPU tests.

This will re-enable display of warnings that a test was expected to
fail, but passed.

BUG=710065
==========

to

==========
Add --passthrough command line arg for Telemetry-based GPU tests.

This will re-enable display of warnings that a test was expected to
fail, but passed.

BUG=710065
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2017-04-23 01:29:22]

The CQ bit was checked by kbr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-23 01:29:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2017-04-23 01:31:48]

kbr@chromium.org changed reviewers:
+ dpranke@chromium.org, nednguyen@google.com

[Ken Russell (switch to Gerrit), 2017-04-23 01:31:48]

PTAL.

Tested locally on macOS and verified that --passthrough displays what's desired.

(Not 100% sure this will do the same on Windows, though expect it to.)

[commit-bot: I haz the power, 2017-04-23 02:38:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-23 02:38:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nednguyen, 2017-04-23 16:50:25]

lgtm

[Ken Russell (switch to Gerrit), 2017-04-24 23:09:41]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2017-04-24 23:09:42]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2832383002/#ps20001
(title: "Preemptive rebase.")

[commit-bot: I haz the power, 2017-04-24 23:10:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 00:26:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493075381898360,
"parent_rev": "0d2e34227539941772c3243cc0d5b31e09b88d01", "commit_rev":
"5d00435578e14a407425e7bd19c7be8727254fe8"}

[commit-bot: I haz the power, 2017-04-25 00:27:54]

Description was changed from

==========
Add --passthrough command line arg for Telemetry-based GPU tests.

This will re-enable display of warnings that a test was expected to
fail, but passed.

BUG=710065
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add --passthrough command line arg for Telemetry-based GPU tests.

This will re-enable display of warnings that a test was expected to
fail, but passed.

BUG=710065
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2832383002
Cr-Commit-Position: refs/heads/master@{#466835}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d00435578e14a407425e7bd19c7...
==========

[commit-bot: I haz the power, 2017-04-25 00:27:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5d00435578e14a407425e7bd19c7...

[Dirk Pranke, 2017-04-25 00:36:33]

Can you post some examples of the difference between --verbose and
--passthrough? I wouldn't have thought passthrough would normally have an effect
for this sort of thing, it's mostly intended for interactive debugging.

[Ken Russell (switch to Gerrit), 2017-04-25 01:23:12]

On 2017/04/25 00:36:33, Dirk Pranke wrote:
> Can you post some examples of the difference between --verbose and
> --passthrough? I wouldn't have thought passthrough would normally have an
effect
> for this sort of thing, it's mostly intended for interactive debugging.

They're attached to
https://bugs.chromium.org/p/chromium/issues/detail?id=710065#c15 .

-vv in particular was much too verbose. --passthrough allowed pretty much
exactly the desired logging through, though due to timestamps and PIDs showing
up in the logs I didn't get to the bottom of all of the differences when adding
it.

[Dirk Pranke, 2017-04-25 01:36:07]

On 2017/04/25 01:23:12, Ken Russell wrote:
> On 2017/04/25 00:36:33, Dirk Pranke wrote:
> > Can you post some examples of the difference between --verbose and
> > --passthrough? I wouldn't have thought passthrough would normally have an
> effect
> > for this sort of thing, it's mostly intended for interactive debugging.
> 
> They're attached to
> https://bugs.chromium.org/p/chromium/issues/detail?id=710065#c15 .
> 
> -vv in particular was much too verbose. --passthrough allowed pretty much
> exactly the desired logging through, though due to timestamps and PIDs showing
> up in the logs I didn't get to the bottom of all of the differences when
adding
> it.

Ah, okay, --passthrough is giving you the stdout output for passed tests that
would otherwise be swallowed. Makes sense, I think.