DescriptionRevert of Embed a single sample in histogram metadata. (patchset #9 id:240001 of https://codereview.chromium.org/2811713003/ )
Reason for revert:
Speculative revert for suspected cause of failing NonThreadSafeDeathTest.DestructorNotAllowedOnDifferentThreadInDebug test on Mac10.9 Tests (dbg).
See https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/39679
Original issue's description:
> Embed a single sample in histogram metadata.
>
> This uses the new DelayedPersistentAllocation to avoid allocating the
> full "counts" array when only one value is being stored. That one
> value is kept in the HistogramSamples metadata. When a second value
> is recorded, the counts-array is created and the single-sample is
> moved; it is there-after unused.
>
> This change only affects SampleVector. A future change may add the
> same support for PersistentSampleMap.
>
> A quick test shows persistent memory use is reduced by 44% (from 924
> KiB to 512 KiB) after a clean start and the loading of three pages:
> chrome://histograms
> https://www.google.com/
> chrome://histograms (again)
>
> BUG=705342
>
> Review-Url: https://codereview.chromium.org/2811713003
> Cr-Commit-Position: refs/heads/master@{#466401}
> Committed: https://chromium.googlesource.com/chromium/src/+/4162bafec82ea11c98d4dc2572337a039b79fdb9
TBR=asvitkine@chromium.org,bcwhite@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=705342
Review-Url: https://codereview.chromium.org/2832333002
Cr-Commit-Position: refs/heads/master@{#466488}
Committed: https://chromium.googlesource.com/chromium/src/+/94191025bc29f325d91565c9520af6495f22be09
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|