Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: content/renderer/media/peer_connection_tracker.cc

Issue 2832263004: Fixing some strings that go into webrtc-internals. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/resources/media/peer_connection_update_table.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/peer_connection_tracker.cc
diff --git a/content/renderer/media/peer_connection_tracker.cc b/content/renderer/media/peer_connection_tracker.cc
index 74af2eb2c796b16b03693b93dae6b2df66c6b1a7..70b6553ab919b059081393fd273f44d945e52603 100644
--- a/content/renderer/media/peer_connection_tracker.cc
+++ b/content/renderer/media/peer_connection_tracker.cc
@@ -177,12 +177,11 @@ static std::string SerializeConfiguration(
const webrtc::PeerConnectionInterface::RTCConfiguration& config) {
std::ostringstream oss;
// TODO(hbos): Add serialization of certificate.
- oss << "{ iceServers: " << SerializeServers(config.servers) << ", "
- << "iceTransportPolicy: " << SerializeIceTransportType(config.type)
- << ", "
- << "bundlePolicy: " << SerializeBundlePolicy(config.bundle_policy) << ", "
- << "rtcpMuxPolicy: " << SerializeRtcpMuxPolicy(config.rtcp_mux_policy)
- << "iceCandidatePoolSize: " << config.ice_candidate_pool_size << " }";
+ oss << "{ iceServers: " << SerializeServers(config.servers)
+ << ", iceTransportPolicy: " << SerializeIceTransportType(config.type)
+ << ", bundlePolicy: " << SerializeBundlePolicy(config.bundle_policy)
+ << ", rtcpMuxPolicy: " << SerializeRtcpMuxPolicy(config.rtcp_mux_policy)
+ << ", iceCandidatePoolSize: " << config.ice_candidate_pool_size << " }";
return oss.str();
}
@@ -191,6 +190,10 @@ static std::string SerializeConfiguration(
result = #state; \
break;
+// Note: All of these strings need to be kept in sync with
+// peer_connection_update_table.js, in order to be displayed as friendly
+// strings on chrome://webrtc-internals.
+
static const char* GetSignalingStateString(
WebRTCPeerConnectionHandlerClient::SignalingState state) {
const char* result = "";
« no previous file with comments | « content/browser/resources/media/peer_connection_update_table.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698