swarming: mechanical changes to unit tests

swarming: mechanical changes to unit tests

This is in preparation to run more task queues as part of the scheduling.

No functional change.

R=vadimsh@chromium.org
BUG=704236
Review-Url: https://codereview.chromium.org/2832243002
Committed: https://github.com/luci/luci-py/commit/606cfbb056276fd6dd2733bf95459dc5539ec73d

[M-A Ruel, 2017-04-21 17:55:40]

This will make the follow up CL more readable as this CL is purely mechanical
test only changes to enable more testing scenarios afterward. It depends on
https://codereview.chromium.org/2832203002/

[M-A Ruel, 2017-04-26 21:10:28]

On 2017/04/21 17:55:40, M-A Ruel wrote:
> This will make the follow up CL more readable as this CL is purely mechanical
> test only changes to enable more testing scenarios afterward. It depends on
> https://codereview.chromium.org/2832203002/

This CL is ready for review.

[Vadim Sh., 2017-04-26 21:30:20]

lgtm

https://codereview.chromium.org/2832243002/diff/20001/appengine/swarming/hand...
File appengine/swarming/handlers_bot_test.py (right):

https://codereview.chromium.org/2832243002/diff/20001/appengine/swarming/hand...
appengine/swarming/handlers_bot_test.py:64:
handlers_backend.TaskDimensionsHandler.tidy_stale(kwargs['payload'])
note that this may incorrectly inherit transaction context of the caller. Maybe
use ndb.non_transactional around _enqueue_task for completness.

[M-A Ruel, 2017-04-26 21:47:43]

https://codereview.chromium.org/2832243002/diff/20001/appengine/swarming/hand...
File appengine/swarming/handlers_bot_test.py (right):

https://codereview.chromium.org/2832243002/diff/20001/appengine/swarming/hand...
appengine/swarming/handlers_bot_test.py:64:
handlers_backend.TaskDimensionsHandler.tidy_stale(kwargs['payload'])
On 2017/04/26 21:30:20, Vadim Sh. wrote:
> note that this may incorrectly inherit transaction context of the caller.
Maybe
> use ndb.non_transactional around _enqueue_task for completness.

Done.

[M-A Ruel, 2017-04-26 21:47:50]

The CQ bit was checked by maruel@chromium.org

[M-A Ruel, 2017-04-26 21:47:51]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2832243002/#ps40001
(title: "Disable tx before calling tq")

[commit-bot: I haz the power, 2017-04-26 21:47:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 21:51:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493243270876870,
"parent_rev": "f7b1beccb66ef34fc7b183e4e6e1287ec0e72658", "commit_rev":
"606cfbb056276fd6dd2733bf95459dc5539ec73d"}

[commit-bot: I haz the power, 2017-04-26 21:51:29]

Description was changed from

==========
swarming: mechanical changes to unit tests

This is in preparation to run more task queues as part of the scheduling.

No functional change.

R=vadimsh@chromium.org
BUG=704236
==========

to

==========
swarming: mechanical changes to unit tests

This is in preparation to run more task queues as part of the scheduling.

No functional change.

R=vadimsh@chromium.org
BUG=704236

Review-Url: https://codereview.chromium.org/2832243002
Committed:
https://github.com/luci/luci-py/commit/606cfbb056276fd6dd2733bf95459dc5539ec73d
==========

[commit-bot: I haz the power, 2017-04-26 21:51:29]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/606cfbb056276fd6dd2733bf95459dc5539ec73d