diagnose_apk_bloat.py: support pre supersize revs.

diagnose_apk_bloat.py: support pre supersize revs.

Previously if you tried to pass a rev created before
tools/binary_size/supersize existed the script would fail. This CL fixes
that by copying supersize to a temporary directory before running any
git/gclient commands.

Also fix _global_restore_checkout_func that became broken in
https://codereview.chromium.org/2834103002/.

BUG=710717
Review-Url: https://codereview.chromium.org/2832223002
Cr-Commit-Position: refs/heads/master@{#466511}
Committed: https://chromium.googlesource.com/chromium/src/+/45ccc6e4217655e9f21e6257062c6e5b82bc22da

[estevenson, 2017-04-21 16:57:13]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org

[agrieve, 2017-04-21 17:00:30]

https://codereview.chromium.org/2832223002/diff/20001/tools/binary_size/diagn...
File tools/binary_size/diagnose_apk_bloat.py (right):

https://codereview.chromium.org/2832223002/diff/20001/tools/binary_size/diagn...
tools/binary_size/diagnose_apk_bloat.py:550: tmp_dir = tempfile.mkdtemp()
This will break helpers.SOURCE_DIR, won't it? Need to pass dir=_SRC_ROOT to
mkdtemp?

[estevenson, 2017-04-21 20:27:03]

https://codereview.chromium.org/2832223002/diff/20001/tools/binary_size/diagn...
File tools/binary_size/diagnose_apk_bloat.py (right):

https://codereview.chromium.org/2832223002/diff/20001/tools/binary_size/diagn...
tools/binary_size/diagnose_apk_bloat.py:550: tmp_dir = tempfile.mkdtemp()
On 2017/04/21 17:00:29, agrieve wrote:
> This will break helpers.SOURCE_DIR, won't it? Need to pass dir=_SRC_ROOT to
> mkdtemp?

Yep, thanks! Missed this when I tested it since it's only used in the html
report now.

[agrieve, 2017-04-21 20:36:48]

lgtm

[estevenson, 2017-04-22 00:08:06]

Description was changed from

==========
diagnose_apk_bloat.py: support pre supersize revs.

Previously if you tried to pass a rev created before
tools/binary_size/supersize existed the script would fail. This CL fixes
that by copying supersize to a temporary directory before running any
git/gclient commands.

BUG=710717
==========

to

==========
diagnose_apk_bloat.py: support pre supersize revs.

Previously if you tried to pass a rev created before
tools/binary_size/supersize existed the script would fail. This CL fixes
that by copying supersize to a temporary directory before running any
git/gclient commands.

Also fix _global_restore_checkout_func that became broken in
https://codereview.chromium.org/2834103002/.

BUG=710717
==========

[estevenson, 2017-04-22 00:27:26]

Gah, also forgot the "global" when setting _global_restore_checkout_func in my
last CL so I fixed here instead of revert/relanding.

[estevenson, 2017-04-22 00:27:44]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2017-04-22 00:27:44]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2832223002/#ps80001
(title: "Fix _global_restore_checkout_func")

[commit-bot: I haz the power, 2017-04-22 00:28:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 00:37:42]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492820864552260,
"parent_rev": "aab90f001ac39ed2fdc19fd81d004d278160db2e", "commit_rev":
"45ccc6e4217655e9f21e6257062c6e5b82bc22da"}

[commit-bot: I haz the power, 2017-04-22 00:38:11]

Description was changed from

==========
diagnose_apk_bloat.py: support pre supersize revs.

Previously if you tried to pass a rev created before
tools/binary_size/supersize existed the script would fail. This CL fixes
that by copying supersize to a temporary directory before running any
git/gclient commands.

Also fix _global_restore_checkout_func that became broken in
https://codereview.chromium.org/2834103002/.

BUG=710717
==========

to

==========
diagnose_apk_bloat.py: support pre supersize revs.

Previously if you tried to pass a rev created before
tools/binary_size/supersize existed the script would fail. This CL fixes
that by copying supersize to a temporary directory before running any
git/gclient commands.

Also fix _global_restore_checkout_func that became broken in
https://codereview.chromium.org/2834103002/.

BUG=710717

Review-Url: https://codereview.chromium.org/2832223002
Cr-Commit-Position: refs/heads/master@{#466511}
Committed:
https://chromium.googlesource.com/chromium/src/+/45ccc6e4217655e9f21e6257062c...
==========

[commit-bot: I haz the power, 2017-04-22 00:38:12]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/45ccc6e4217655e9f21e6257062c...